Skip to content

[lua] Chocobo riding game reward fix#9889

Merged
Xaver-DaRed merged 1 commit into
LandSandBoat:basefrom
CriticalXI:riding_game_fix
Apr 29, 2026
Merged

[lua] Chocobo riding game reward fix#9889
Xaver-DaRed merged 1 commit into
LandSandBoat:basefrom
CriticalXI:riding_game_fix

Conversation

@CriticalXI
Copy link
Copy Markdown
Contributor

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

  • I was calculating the clear time again when the reward was sent to the player rather than when they actually finished the race, resulting in giving the wrong reward if the player sat on the event dialogue too long.
  • General styling updates

Steps to test these changes

  • Try a race, and sit on the event dialogue for awhile so it goes over the reward threshold to the next tier
  • See you still get the reward for what time you entered the trigger area

@Xaver-DaRed Xaver-DaRed merged commit addd1a7 into LandSandBoat:base Apr 29, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants