[core] Introduce Transaction base, ItemUseTransaction.#9929
Merged
Conversation
Xaver-DaRed
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I affirm:
What does this pull request do?
Transaction base
Only ItemAccess can flip an item in and out of a transaction. Only Transaction can access these functions on ItemAccess.
There will be more checks added in next PRs to ensure you cannot create duplicate transactions etc.
ItemUseTransaction
There's a little bit of an edge case because ItemState cannot represent an item as both Equipped and InTransaction as it is - I'll revisit that later as there is still the ITEM_LOCKED backstop in place.
Steps to test these changes
Some tests included + ran through a manual checklist.