[cpp] Adds missing ranged attack animations for Fomor, Quadav and Kindred#9930
Merged
Conversation
WinterSolstice8
approved these changes
May 4, 2026
7f9ae74 to
e483a2a
Compare
Adds player ranged attacked for mobs for all the hume/fomor models. Adds quadav ranged attacks Adds Kindred ranged attacks Adds mobmod for ranged attack range for mobs to be default 14 and moveable
Xaver-DaRed
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I affirm:
What does this pull request do?
This fix turned into more than I bargained for. What was supposed to be a simple "animation" fix turned out to be allowing mobs to use player ranged attacks.
This PR adds support for MOBs to use player-style ranged auto-attacks.
Previously, ranged attacks were effectively limited to player controller flow / mob special skill workarounds. This adds ranged attack support to the generic controller path so MOBs can enter
CRangeState, perform a ranged attack action, and use ranged attack timing/range logic.What Changed
CController::RangedAttack.CAIContainer::RangedAttackso it no longer only routes throughCPlayerController.setRangedAttackEnabled()andisRangedAttackEnabled()Lua bindings for enabling ranged auto-attacks on MOBs.MOBMOD_RANGED_ATTACK_RANGE/xi.mobMod.RANGED_ATTACK_RANGEso MOB ranged attack distance can be configured.CRangeStateto use the entity’s ranged attack range instead of a hard-coded 25-yalm check.CBattleEntity::OnRangedAttack, including hit checks, crits, shadows, ranged damage, and action packet result handling.ore_toss_ranged.luaas a ranged auto-attack style for Quadav (Added TODOs for FTPs)hecatomb_wave_ra.luaas ranged auto-attack style for Kindred (Added TODOs for % damage/cap)https://youtu.be/L7XsPrM4D4Q - LSB Video
Captures:
https://youtu.be/0b0k_CUQUp8
Ore Toss
https://youtu.be/_DgjxpcvDpE?t=1875
https://www.dropbox.com/scl/fi/i2z822zhnaewsw4fsn6wx/Dynamis-Bastok-mobskill-testing.zip?dl=0&e=1&file_subpath=%2FDynamis+Bastok+mobskill+testing%2FSiknawz%2Factionview%2Fsimple%2FDynamis+-+Bastok.log&rlkey=hx9dhxsjxf51q8i17lkgxfomd
Hecatomb Wave
https://www.youtube.com/watch?v=rGBmQPTxQ54
https://www.dropbox.com/scl/fi/3itqsjrihkjctszh99i89/Dynamis-Xarcabard-General-farming.zip?dl=0&e=1&file_subpath=%2FDynamis+Xarcabard+-+General+farming%2FSiknoz%2Factionview%2Fsimple%2FDynamis+-+Xarcabard.log&rlkey=29eg73glfpeovd9792mif3he8
Steps to test these changes
Auto-attack fomor:
!gotoid 16887904
hit it and run around, stand in melee, etc.
!gotoid 16887906
hit it and run around, stand in melee, etc.
Qudav:
!gotoid 17539087
hit it and run around, stand in melee, etc.
Kindred:
!gotoid 16949355
hit it and run around, stand in melee, etc.