[core] Crit fail synthesis/cancel fishing on attack; streamline ATTACK/ON_ATTACK buffs removal#9935
Merged
Conversation
930c0bd to
6ea4140
Compare
6ea4140 to
362730d
Compare
Contributor
Author
|
Undrafted, had to tweak the way the crafting animation is cancelled. |
Xaver-DaRed
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I affirm:
What does this pull request do?
ON_ATTACKwhen performing or receiving hostile actions (actor/target)DETECTABLEon receiving any hostile action (main target)ATTACKon outgoing autos and WSLittle bit of a clusterfuck when this should really all exist on
CBattleEntitybut the way the code is laid out doesn't permit it easily.Does not touch existing actor DETECTABLE as it's too complex without breaking Hide/Camouflage
Closes #9049 #9050 #860 #8729
Steps to test these changes
Still testing a little bit more.