Skip to content

[lua] Fix Water Way to Go trade item not consumed on completion#9948

Merged
Xaver-DaRed merged 1 commit into
LandSandBoat:basefrom
Millhouse1337:fix-water-way-to-go-trade-item
May 5, 2026
Merged

[lua] Fix Water Way to Go trade item not consumed on completion#9948
Xaver-DaRed merged 1 commit into
LandSandBoat:basefrom
Millhouse1337:fix-water-way-to-go-trade-item

Conversation

@Millhouse1337
Copy link
Copy Markdown
Contributor

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Closes #7926.

When the player trades the Canteen of Giddeus Water to Ohbiru-Dohbiru to complete Water Way to Go, the gil reward is granted but the canteen is not removed from inventory. The bug is in the handler for event 355 (the quest-completion cutscene): it called player:tradeComplete() instead of player:confirmTrade(), so the trade items were never consumed.

This PR replaces that single call. confirmTrade() matches the canonical pattern used by every other Windurst trade-completion quest:

  • scripts/quests/windurst/A_Smudge_on_Ones_Record.lua (event [417])
  • scripts/quests/windurst/Blast_from_the_Past.lua (event [224])
  • scripts/quests/windurst/All_At_Sea.lua (event [295])
  • scripts/quests/windurst/Curses_Foiled_Again_1.lua (event [173])

…and the working event [55] handler in this same file (the earlier trade where the Giddeus Spring fills the empty canteen).

Steps to test these changes

On a character that has completed Overnight Delivery and has Windurst fame ≥ 3:

  1. !addquest 2 16 (adds Water Way to Go in QUEST_ACCEPTED state)
  2. !additem 4351 (Canteen of Giddeus Water)
  3. Travel to Windurst Waters and trade the canteen to Ohbiru-Dohbiru
  4. Watch the cutscene complete

Verify after the event:

  • Water Way to Go shows as completed in the quest log
  • Player gained 900 gil
  • Canteen of Giddeus Water is no longer in inventory (this was the bug)

When the player trades the Canteen of Giddeus Water to Ohbiru-Dohbiru
to complete the quest, the gil reward is granted but the canteen is
not removed from inventory. The bug is in the handler for event 355
(the quest-completion cutscene): it called tradeComplete() instead of
confirmTrade(), so the trade items were never consumed.

This change replaces that single call. confirmTrade() matches the
canonical pattern used by every other Windurst trade-completion quest
(A_Smudge_on_Ones_Record, Blast_from_the_Past, All_At_Sea, etc.) and
the working event 55 handler in this same file (the earlier trade
where the Giddeus Spring fills the empty canteen).

Tested in-game: traded the canteen to Ohbiru-Dohbiru, confirmed the
item is now consumed, gil is awarded, and the quest completes.

Fixes LandSandBoat#7926
@Xaver-DaRed Xaver-DaRed merged commit 10a2abc into LandSandBoat:base May 5, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 Windurst Quest “Water Way to Go!” – Trade Item “Giddeus Water” remains in your inventory.

3 participants