[lua] Fix Water Way to Go trade item not consumed on completion#9948
Merged
Xaver-DaRed merged 1 commit intoMay 5, 2026
Merged
Conversation
When the player trades the Canteen of Giddeus Water to Ohbiru-Dohbiru to complete the quest, the gil reward is granted but the canteen is not removed from inventory. The bug is in the handler for event 355 (the quest-completion cutscene): it called tradeComplete() instead of confirmTrade(), so the trade items were never consumed. This change replaces that single call. confirmTrade() matches the canonical pattern used by every other Windurst trade-completion quest (A_Smudge_on_Ones_Record, Blast_from_the_Past, All_At_Sea, etc.) and the working event 55 handler in this same file (the earlier trade where the Giddeus Spring fills the empty canteen). Tested in-game: traded the canteen to Ohbiru-Dohbiru, confirmed the item is now consumed, gil is awarded, and the quest completes. Fixes LandSandBoat#7926
WinterSolstice8
approved these changes
May 5, 2026
Xaver-DaRed
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I affirm:
What does this pull request do?
Closes #7926.
When the player trades the Canteen of Giddeus Water to Ohbiru-Dohbiru to complete Water Way to Go, the gil reward is granted but the canteen is not removed from inventory. The bug is in the handler for event 355 (the quest-completion cutscene): it called
player:tradeComplete()instead ofplayer:confirmTrade(), so the trade items were never consumed.This PR replaces that single call.
confirmTrade()matches the canonical pattern used by every other Windurst trade-completion quest:scripts/quests/windurst/A_Smudge_on_Ones_Record.lua(event[417])scripts/quests/windurst/Blast_from_the_Past.lua(event[224])scripts/quests/windurst/All_At_Sea.lua(event[295])scripts/quests/windurst/Curses_Foiled_Again_1.lua(event[173])…and the working event
[55]handler in this same file (the earlier trade where the Giddeus Spring fills the empty canteen).Steps to test these changes
On a character that has completed Overnight Delivery and has Windurst fame ≥ 3:
!addquest 2 16(adds Water Way to Go in QUEST_ACCEPTED state)!additem 4351(Canteen of Giddeus Water)Verify after the event: