Skip to content

[core] Simplify magic/ranged state hasMoved()#9951

Merged
Xaver-DaRed merged 1 commit into
LandSandBoat:basefrom
WinterSolstice8:magic_ranged_wiggleroom
May 5, 2026
Merged

[core] Simplify magic/ranged state hasMoved()#9951
Xaver-DaRed merged 1 commit into
LandSandBoat:basefrom
WinterSolstice8:magic_ranged_wiggleroom

Conversation

@WinterSolstice8
Copy link
Copy Markdown
Contributor

@WinterSolstice8 WinterSolstice8 commented May 5, 2026

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

See title - magic/ranged state hasMoved was complicated for seemingly no good reason when you can just use distance

.3 yalms is used from approx this video
We'll get more precise data later but this is .25~ish so close enough.
Vertical axis seems to be ignored on retail.

Steps to test these changes

/ra or cast spell, wiggle a bit from your original position and still be able to cast

@sruon
Copy link
Copy Markdown
Contributor

sruon commented May 5, 2026

Retail test https://youtu.be/uryLJSRRouE

Didn't record but RA test produced the same result.

@Xaver-DaRed Xaver-DaRed merged commit 49ec2a0 into LandSandBoat:base May 5, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants