[core] Simplify magic/ranged state hasMoved()#9951
Merged
Xaver-DaRed merged 1 commit intoMay 5, 2026
Conversation
Contributor
|
Retail test https://youtu.be/uryLJSRRouE Didn't record but RA test produced the same result. |
sruon
approved these changes
May 5, 2026
Xaver-DaRed
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I affirm:
What does this pull request do?
See title - magic/ranged state hasMoved was complicated for seemingly no good reason when you can just use
distance.3 yalms is used from approx this video
We'll get more precise data later but this is .25~ish so close enough.
Vertical axis seems to be ignored on retail.
Steps to test these changes
/ra or cast spell, wiggle a bit from your original position and still be able to cast