[cpp, lua] Change delay to have the in-game input instead of milliseonds#9960
Merged
Conversation
caf61d6 to
6aac712
Compare
Contributor
Author
|
Tested: |
For whatever reason we were converting to the in-game delay in every single delay call instead of just changing the base function
Xaver-DaRed
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I affirm:
What does this pull request do?
For whatever reason we were converting to the in-game delay in every single delay call instead of just changing the base function. This changes all the setDelay calls to use the observed in-game delay.
no more
set:delay(2400)set:delay(240)Yes this conversation makes no sense if you look at the code...but some assumed it was 2400m and some did the correct conversion. Ex.:
set:delay(8000)->set:delay(480)A lot of people assumed the setDelay were always in milliseconds so there are a few delays that might break. I did my best to determine the correct delay of each call.
Steps to test these changes
https://www.youtube.com/watch?v=B86PA_Q3-6g
Go attack any mob and see its delay not change. I did NOT test every single mob in the game so there are some mobs that may be inaccurate for this to happen.