Skip to content

[cpp, lua] Change delay to have the in-game input instead of milliseonds#9960

Merged
Xaver-DaRed merged 1 commit into
LandSandBoat:basefrom
Frankie-hz:delay
May 6, 2026
Merged

[cpp, lua] Change delay to have the in-game input instead of milliseonds#9960
Xaver-DaRed merged 1 commit into
LandSandBoat:basefrom
Frankie-hz:delay

Conversation

@Frankie-hz
Copy link
Copy Markdown
Contributor

@Frankie-hz Frankie-hz commented May 6, 2026

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

For whatever reason we were converting to the in-game delay in every single delay call instead of just changing the base function. This changes all the setDelay calls to use the observed in-game delay.

no more set:delay(2400)
set:delay(240)
Yes this conversation makes no sense if you look at the code...but some assumed it was 2400m and some did the correct conversion. Ex.: set:delay(8000) -> set:delay(480)

A lot of people assumed the setDelay were always in milliseconds so there are a few delays that might break. I did my best to determine the correct delay of each call.

Steps to test these changes

https://www.youtube.com/watch?v=B86PA_Q3-6g

Go attack any mob and see its delay not change. I did NOT test every single mob in the game so there are some mobs that may be inaccurate for this to happen.

@Frankie-hz Frankie-hz force-pushed the delay branch 6 times, most recently from caf61d6 to 6aac712 Compare May 6, 2026 06:51
@Frankie-hz Frankie-hz marked this pull request as ready for review May 6, 2026 06:54
@Frankie-hz
Copy link
Copy Markdown
Contributor Author

Tested:
Hundred Fists
Player Ranged Attacks
Mob auto-attack ranged attacks
Mob ranged weaponskills
Regular attacks on mobs and players

For whatever reason we were converting to the in-game delay in every single delay call instead of just changing the base function
@Xaver-DaRed Xaver-DaRed merged commit 209b3b5 into LandSandBoat:base May 6, 2026
10 checks passed
@Frankie-hz Frankie-hz deleted the delay branch May 15, 2026 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants