Skip to content

UI width#141

Merged
daisyli-qcif merged 2 commits intonew-apifrom
ui-width
Feb 18, 2026
Merged

UI width#141
daisyli-qcif merged 2 commits intonew-apifrom
ui-width

Conversation

@daisyli-qcif
Copy link

Fort ticket#140 Fix the issue where the list doesnt fill up the space

@daisyli-qcif daisyli-qcif merged commit 9726006 into new-api Feb 18, 2026
1 check passed
"files": {
"ignoreUnknown": false,
"includes": ["**", "!dist", "!**/package.json", "!**/vocab.json", "!public/configuration.json"]
"includes": ["**", "!portal/dist", "!**/package.json", "!**/vocab.json", "!public/configuration.json"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@daisyli-qcif Can you revert this part of the change. I think the portal directory might be left over from when you built on the main branch.
When you build on the new-api branch it creates the dist directory at the top level

Copy link
Author

@daisyli-qcif daisyli-qcif Feb 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@johnf I have reverted in branch new-api. Without this change, Git doesn't allow me commit and push branch ui-width to branch new-api :

LIFECYCLE  Command failed with exit code 1. ──────────────────────────────────── summary: (done in 4.98 seconds) ✔️ lint-types (0.97 seconds) ✔️ lint-knip (2.83 seconds) 🥊 lint-biome (4.98 seconds) daisyli@DaisyLiQCIF:~/RAPID/oni-ui$ git config --global user.name daisyli-qcif daisyli@DaisyLiQCIF:~/RAPID/oni-ui$ git config --global user.email daisy.li@qcif.edu.au daisyli@DaisyLiQCIF:~/RAPID/oni-ui$ git config --global --list user.name=daisyli-qcif user.email=daisy.li@qcif.edu.au daisyli@DaisyLiQCIF:~/RAPID/oni-ui$ git commit -m "resize filter buttons and list" ╭──────────────────────────────────────╮ │ 🥊 lefthook v2.0.5 hook: pre-commit │ ╰──────────────────────────────────────╯ ┃ lint-types ❯ > oni-ui@2.1.5 lint:types /home/daisyli/RAPID/oni-ui > tsc --noEmit ┃ lint-knip ❯ > oni-ui@2.1.5 lint:knip /home/daisyli/RAPID/oni-ui > knip Configuration hints (1) scripts/fetch-vocabs.mts knip.ts Remove from ignoreBinaries ✂️ Excellent, Knip found no issues. ┃ lint-biome ❯ > oni-ui@2.1.5 lint:biome /home/daisyli/RAPID/oni-ui > biome check . portal/dist/c6b3dd9971057eecced2.js:10:7 lint/complexity/useLiteralKeys FIXABLE ━━━━━━━━━━━━━━━━━━ ℹ The computed expression can be simplified without the use of a string literal. 8 │ * If you are looking for production-ready output files, see mode: "production" (https://webpack.js.org/configuration/mode/). 9 │ */ > 10 │ (self["webpackChunkoni_ui_vue"] = self["webpackChunkoni_ui_vue"] || []).push([["node_modules_manku-icon-lib_dist_binderlink-8d3acc55_js"],{ │ ^^^^^^^^^^^^^^^^^^^^^^^^ 11 │ 12 │ /***/ "./node_modules/manku-icon-lib/dist/binderlink-8d3acc55.js": ℹ Unsafe fix: Use a literal key instead. 
ℹ See the MDN web docs for more details. ℹ Refactor the code so that it doesn't need to call eval(). The number of diagnostics exceeds the limit allowed. Use --max-diagnostics to increase it. Diagnostics not shown: 772. Checked 113 files in 3s. No fixes applied. Found 132 errors. Found 623 warnings. Found 36 infos. check ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ ✖ Some errors were emitted while running checks.  ELIFECYCLE  Command failed with exit code 1. ──────────────────────────────────── summary: (done in 4.78 seconds) ✔️ lint-types (0.89 seconds) ✔️ lint-knip (2.63 seconds) 🥊 lint-biome (4.77 seconds)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can simply remove portal/dist it is left over from before

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean the whole folder in my local repo, right?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it would have been created when you did a pnpm build in the main branch

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants