Merged
Conversation
johnf
reviewed
Feb 18, 2026
| "files": { | ||
| "ignoreUnknown": false, | ||
| "includes": ["**", "!dist", "!**/package.json", "!**/vocab.json", "!public/configuration.json"] | ||
| "includes": ["**", "!portal/dist", "!**/package.json", "!**/vocab.json", "!public/configuration.json"] |
Collaborator
There was a problem hiding this comment.
@daisyli-qcif Can you revert this part of the change. I think the portal directory might be left over from when you built on the main branch.
When you build on the new-api branch it creates the dist directory at the top level
Author
There was a problem hiding this comment.
@johnf I have reverted in branch new-api. Without this change, Git doesn't allow me commit and push branch ui-width to branch new-api :
LIFECYCLE Command failed with exit code 1. ──────────────────────────────────── summary: (done in 4.98 seconds) ✔️ lint-types (0.97 seconds) ✔️ lint-knip (2.83 seconds) 🥊 lint-biome (4.98 seconds) daisyli@DaisyLiQCIF:~/RAPID/oni-ui$ git config --global user.name daisyli-qcif daisyli@DaisyLiQCIF:~/RAPID/oni-ui$ git config --global user.email daisy.li@qcif.edu.au daisyli@DaisyLiQCIF:~/RAPID/oni-ui$ git config --global --list user.name=daisyli-qcif user.email=daisy.li@qcif.edu.au daisyli@DaisyLiQCIF:~/RAPID/oni-ui$ git commit -m "resize filter buttons and list" ╭──────────────────────────────────────╮ │ 🥊 lefthook v2.0.5 hook: pre-commit │ ╰──────────────────────────────────────╯ ┃ lint-types ❯ > oni-ui@2.1.5 lint:types /home/daisyli/RAPID/oni-ui > tsc --noEmit ┃ lint-knip ❯ > oni-ui@2.1.5 lint:knip /home/daisyli/RAPID/oni-ui > knip Configuration hints (1) scripts/fetch-vocabs.mts knip.ts Remove from ignoreBinaries ✂️ Excellent, Knip found no issues. ┃ lint-biome ❯ > oni-ui@2.1.5 lint:biome /home/daisyli/RAPID/oni-ui > biome check . portal/dist/c6b3dd9971057eecced2.js:10:7 lint/complexity/useLiteralKeys FIXABLE ━━━━━━━━━━━━━━━━━━ ℹ The computed expression can be simplified without the use of a string literal. 8 │ * If you are looking for production-ready output files, see mode: "production" (https://webpack.js.org/configuration/mode/). 9 │ */ > 10 │ (self["webpackChunkoni_ui_vue"] = self["webpackChunkoni_ui_vue"] || []).push([["node_modules_manku-icon-lib_dist_binderlink-8d3acc55_js"],{ │ ^^^^^^^^^^^^^^^^^^^^^^^^ 11 │ 12 │ /***/ "./node_modules/manku-icon-lib/dist/binderlink-8d3acc55.js": ℹ Unsafe fix: Use a literal key instead.
ℹ See the MDN web docs for more details. ℹ Refactor the code so that it doesn't need to call eval(). The number of diagnostics exceeds the limit allowed. Use --max-diagnostics to increase it. Diagnostics not shown: 772. Checked 113 files in 3s. No fixes applied. Found 132 errors. Found 623 warnings. Found 36 infos. check ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ ✖ Some errors were emitted while running checks. ELIFECYCLE Command failed with exit code 1. ──────────────────────────────────── summary: (done in 4.78 seconds) ✔️ lint-types (0.89 seconds) ✔️ lint-knip (2.63 seconds) 🥊 lint-biome (4.77 seconds)
Collaborator
There was a problem hiding this comment.
You can simply remove portal/dist it is left over from before
Author
There was a problem hiding this comment.
You mean the whole folder in my local repo, right?
Collaborator
There was a problem hiding this comment.
Yes, it would have been created when you did a pnpm build in the main branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fort ticket#140 Fix the issue where the list doesnt fill up the space