Fix the date range field #1036
Merged
Fix the date range field #1036
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lloy0076
reviewed
Oct 1, 2017
| $formattedDate = null; | ||
| if (isset($entry) && !empty($entry->{$dateFieldName})) { | ||
| $dateField = $entry->{$dateFieldName}; | ||
| if ($dateField instanceof \Carbon\Carbon || $dateField instanceof \Jenssegers\Date\Date) { |
Contributor
There was a problem hiding this comment.
I wonder if we should attempt to just "duck type" this (i.e. if it's an object that has the format method then call the format method).
Member
|
Thank you @tumf87 ! Tested, merged on dev! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The date range field didn't work when the Laravel date mutators were not configured for the start and end date columns, in which case those dates were plain strings by default.