Use increased default height for elFinder (standalone) view#84
Merged
pxpm merged 1 commit intoMar 25, 2026
Merged
Conversation
Contributor
|
Thanks @jnoordsij 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY
BEFORE - What was wrong? What was happening before this PR?
The default size of the elFinder instance is rather small when used in a standalone manner on a device with larger screen(s);
see e.g. https://demo.backpackforlaravel.com/admin/elfinder#elf_l1_Lw:
This is due to elFinder default value of 400 (pixels); see https://github.com/Studio-42/elFinder/wiki/Client-configuration-options-2.1#height.
AFTER - What is happening after this PR?
By updating the height to be 80%, the default page layout looks much more sane to me.
HOW
How did you achieve that, in technical terms?
Set the default value.
Is it a breaking change or non-breaking change?
I would say a behavioral but non-breaking change.
How can we test the before & after?
Compare the instance sizes.