Load jquery-ui smoothness theme for elFinder#89
Merged
Conversation
jnoordsij
force-pushed
the
load-jquery-ui
branch
from
26e3f01 to
c482f18
Compare
pxpm
reviewed
Mar 26, 2026
Co-authored-by: Pedro Martins <pxpm88@gmail.com>
jnoordsij
force-pushed
the
load-jquery-ui
branch
from
ff78ae8 to
3d9fcaa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY
BEFORE - What was wrong? What was happening before this PR?
As css for jquery-ui is not loaded, various UI elements are positioned incorrectly and/or behave incorrectly.
Some examples:
These can all be observed on the current demo deployment @ https://demo.backpackforlaravel.com/admin/elfinder#elf_l1_Lw:
AFTER - What is happening after this PR?
By adding the css, this all works again, similar to the demo at https://studio-42.github.io/elFinder/#elf_l1_Lw.
For consistency I've also bumped the js to the same (latest) version.
Note: there is some change in icons that all get a border. I've not yet debugged if this is unintentional or can be circumvented in any way, but I don't find it too annoying. I've also not found a 'complete example/demo' leveraging the same theme used here for reference for comparison, that might help if one is to find it.
HOW
How did you achieve that, in technical terms?
The default elFinder setup comes with loading jquery-ui smoothness theme; see for example the demo at https://studio-42.github.io/elFinder/#elf_l1_Lw which has
<link type="text/css" rel="stylesheet" href="//code.jquery.com/ui/1.13.2/themes/smoothness/jquery-ui.css">in the HTML.In this repo the js file was still loaded, but the css no longer was, causing discrepancies.
Is it a breaking change or non-breaking change?
non-breaking
How can we test the before & after?
compare demo to new version 😉