New action-in-bulk-action-group Rule#12
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new best-practices rule that detects
Action::make()used insidetoolbarActions()/BulkActionGroup::make()and suggests replacing it withBulkAction::make(). The rule is auto-fixable and also adds the missinguse Filament\Actions\BulkAction;import.This is a common mistake in AI-generated Filament code — the code compiles and looks correct at first glance, but bulk actions require
BulkAction::make()to receive the selected$recordscollection at runtime.What it detects
Action::make()insideBulkActionGroup::make()Action::make()directly insidetoolbarActions()Tabletype-hinted parameter (not justtable()— e.g.configure(Table $table))Before
After
Resolves #11