fix: handle help menu as a route to avoid closing the app on dismiss#89
Merged
LargeModGames merged 2 commits intoLargeModGames:mainfrom Feb 9, 2026
Merged
Conversation
Owner
|
@all-contributors please add @dpnova for code |
Contributor
|
I've put up a pull request to add @dpnova! 🎉 |
LargeModGames
added a commit
that referenced
this pull request
Feb 9, 2026
Adds @dpnova as a contributor for code. This was requested by LargeModGames [in this comment](#89 (comment)) [skip ci]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The second time you close the help screen it closes the whole app.
This moves HelpMenu to be a route in its own right to avoid accidentally popping off an empty stack when you hit "q" on the second opening of help.
Also added some other tests for HelpMenu
Testing
test result: ok. 51 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.01s