Fixed Windows compilation bug introduced in v0.36.0#97
Merged
LargeModGames merged 1 commit intoLargeModGames:mainfrom Feb 13, 2026
Merged
Fixed Windows compilation bug introduced in v0.36.0#97LargeModGames merged 1 commit intoLargeModGames:mainfrom
LargeModGames merged 1 commit intoLargeModGames:mainfrom
Conversation
Signed-off-by: Tyler McCann <tyler@proxbox.dev>
Owner
|
that was pretty dumb from me, thanks for the fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Version v0.36.0 introduced a minor issue that resulted in the project not successfully building on Windows hosts. A Linux-only feature --
mpris-- was added to the default list of features despite being internally labeled as optional.So specifically, all this PR does is remove the optional Linux-only feature
mprisfrom the default list withinCargo.toml, fixing Windows compilation.Testing
Compilation failure at line 302 of
main.rsdue to being unable to locatemprison a Windows host.Root cause being this "optional" feature being included in the "default" list within
Cargo.toml.Compilation in both Windows and Linux successful after removing
mprisfrom the default list.