feat: add and remove song from playlist#99
Merged
LargeModGames merged 3 commits intoLargeModGames:mainfrom Feb 15, 2026
Merged
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cebf870143
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
nthpaul
commented
Feb 14, 2026
nthpaul
commented
Feb 14, 2026
nthpaul
commented
Feb 14, 2026
nthpaul
commented
Feb 14, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds comprehensive playlist track management functionality to the TUI, enabling users to add tracks to playlists and remove tracks from playlists with position-aware semantics.
Changes:
- Adds 'w' key binding to add selected/playing tracks to a playlist via an interactive picker dialog
- Adds 'W' global shortcut for quick-add of currently playing track
- Adds 'x' key binding to remove selected track from current playlist with confirmation dialog
- Implements position-based removal that preserves duplicate tracks by removing only the selected occurrence
- Adds error handling for local/unavailable tracks and playlist sync validation
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/app.rs | Adds state structures (PendingPlaylistTrackAdd, PendingPlaylistTrackRemoval), playlist_track_positions field, and begin_add_track_to_playlist_flow method |
| src/network.rs | Implements AddTrackToPlaylist and RemoveTrackFromPlaylistAtPosition IoEvents with full playlist fetching, position validation, and chunked replacement logic; adds position tracking in set_playlist_tracks_to_table and sorting |
| src/handlers/track_table.rs | Adds 'w' and 'x' handlers with playlist context validation and position resolution |
| src/handlers/playbar.rs | Adds 'w' handler and add_currently_playing_track_to_playlist function with episode filtering |
| src/handlers/dialog.rs | Refactors dialog handler to support AddTrackToPlaylistPicker and RemoveTrackFromPlaylistConfirm contexts with vim-style navigation |
| src/handlers/mod.rs | Adds global 'W' shortcut with input/dialog mode exclusion |
| src/handlers/empty.rs | Delegates 'w' to playbar handler when hovering over PlayBar |
| src/ui/mod.rs | Refactors draw_dialog to support multiple dialog contexts with dedicated picker and confirmation rendering functions |
| src/ui/help.rs | Adds help text entries for new keybindings |
Owner
|
This is amazing tysm! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
h/lnavigation for confirmation buttons.Testing
/Users/ple/.cargo/bin/cargo fmt --all/Users/ple/.cargo/bin/cargo test -q network::tests -- --nocapture/Users/ple/.cargo/bin/cargo test -qAdditional notes
urispayload.