Skip to content

Fixed windows GA to create draft release#19

Merged
Larry8668 merged 2 commits intomainfrom
feat-github-action-release
Oct 13, 2025
Merged

Fixed windows GA to create draft release#19
Larry8668 merged 2 commits intomainfrom
feat-github-action-release

Conversation

@Larry8668
Copy link
Copy Markdown
Owner

@Larry8668 Larry8668 commented Oct 13, 2025

Summary by CodeRabbit

  • New Features

    • Windows builds now generate draft releases with installers (MSI and NSIS), including autogenerated release notes and versioned tags/names.
  • Chores

    • Adjusted Linux and macOS build workflows to disable automatic runs on pushes to the main branch. No changes to app functionality.

@Larry8668 Larry8668 self-assigned this Oct 13, 2025
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Oct 13, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Disables push-based triggers for Linux and macOS GitHub Actions workflows. Adds a conditional “Create Release” step to the Windows workflow that drafts a GitHub release on main, uploading MSI and NSIS artifacts, with generated notes and versioning based on the run number.

Changes

Cohort / File(s) Summary
Trigger adjustments (disable push on main)
.github/workflows/build-linux.yml, .github/workflows/build-macos.yml
Comment out on.push.branches: [ main ], effectively disabling push-triggered runs; no step or environment changes.
Windows release automation
.github/workflows/build-windows.yml
Add “Create Release” step using softprops/action-gh-release@v1, conditional on main, continue-on-error, creating draft release with generated notes; uploads MSI/NSIS artifacts; tags as v<run_number> and names release “PathFinder v<run_number>”.

Sequence Diagram(s)

sequenceDiagram
    autonumber
    participant Dev as Developer
    participant GH as GitHub (main)
    participant Runner as Actions Runner (Windows)
    participant Release as softprops/action-gh-release@v1

    Dev->>GH: Push/merge to main
    GH->>Runner: Trigger Windows workflow
    Runner->>Runner: Build & package (MSI/NSIS)
    Runner->>Runner: Upload artifacts
    rect rgba(200, 245, 200, 0.3)
    note over Runner: New step (conditional on main)<br/>continue-on-error: true
    Runner->>Release: Create draft release<br/>tag: v<run_number><br/>name: PathFinder v<run_number><br/>generate notes
    Release-->>Runner: Release URL / result
    end
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

Thump-thump goes my fluffy heart,
Linux, macOS take a pause, so smart—
Windows hops to draft a release,
Tagging runs with numbered ease.
I nibble carrots, artifacts in tow,
“PathFinder” shines—onward we go! 🥕✨

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat-github-action-release

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4196a50 and 34c38ca.

📒 Files selected for processing (3)
  • .github/workflows/build-linux.yml (1 hunks)
  • .github/workflows/build-macos.yml (1 hunks)
  • .github/workflows/build-windows.yml (1 hunks)

Comment @coderabbitai help to get the list of available commands and usage tips.

@Larry8668 Larry8668 merged commit 41e9f59 into main Oct 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant