Multithreading improvements #1
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[IMP] Add merge status on closed pull requests
As it is possible to pass a file content instead of a file path to Kaptan, a handler must be resolved before it happens. Though, it's better to make an extra safety step and use Kaptan's own logic to determine a suitable handler than to use bare file extension.
…nsions Let Kaptan pick the handler of it's own choice
* Move repo aggregation into a helper method * Add option for the amount of processes to use when aggregating * Use multiprocessing pool for aggregation if aforementioned option is enabled
[ADD] 'jobs' parameter, set max parallel threads execution. [ADD] Multithreading when jobs > 1. [REF] Remove 'os.chdir' and 'utils.WorkingDirectoryKeeper' calls, use 'cwd' instead. [FIX] Ignore local hooks in 'test_repo.git_write_commit'. [ADD] Multithreading tests (WIP).
crimoniv
force-pushed
the
feature/thread-download
branch
from
05d8bcb to
9fdb214
Compare
Author
|
Closed as of acsone#21 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @lasley!
Hope you don't mind the code refactor in order to get the multithreading working. I've also added tests and improved the logging messages (especially when using multithreading).
Tell me what you think :)
Cheers!