Skip to content

[FIX] carepoint: Fix sequence generation#21

Merged
tedsalmon merged 1 commit intorelease/0.1from
bugfix/0.1/fix-sequence
Oct 19, 2016
Merged

[FIX] carepoint: Fix sequence generation#21
tedsalmon merged 1 commit intorelease/0.1from
bugfix/0.1/fix-sequence

Conversation

@lasley
Copy link
Copy Markdown
Member

@lasley lasley commented Oct 19, 2016

  • Call execute directly on connection to allow params

Before:

>>> cp = Carepoint(
...     server='10.0.13.73',
...     user='test_odoo',
...     passwd='',
... )
>>> cp.get_next_sequence('pat_id')
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "carepoint/db/carepoint.py", line 338, in get_next_sequence
    seq_name=sequence_name,
  File "/root/_venv/local/lib/python2.7/site-packages/sqlalchemy/orm/session.py", line 1104, in execute
    bind = self.get_bind(mapper, clause=clause, **kw)
TypeError: get_bind() got an unexpected keyword argument 'seq_name'

After:

>>> cp = Carepoint(
...     server='10.0.13.73',
...     user='test_odoo',
...     passwd='',
... )
>>> cp.get_next_sequence('pat_id')
1103

* Call execute directly on connection to allow params
@lasley lasley force-pushed the bugfix/0.1/fix-sequence branch from bf9c89c to 7d8164c Compare October 19, 2016 02:49
@codecov-io
Copy link
Copy Markdown

codecov-io commented Oct 19, 2016

Current coverage is 97.63% (diff: 100%)

Merging #21 into release/0.1 will not change coverage

@@           release/0.1        #21   diff @@
=============================================
  Files               59         59          
  Lines             1562       1562          
  Methods              0          0          
  Messages             0          0          
  Branches            38         38          
=============================================
  Hits              1525       1525          
  Misses              19         19          
  Partials            18         18          

Powered by Codecov. Last update d70b452...7d8164c

Copy link
Copy Markdown
Contributor

@tedsalmon tedsalmon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM :)

@tedsalmon tedsalmon merged commit 1f3316e into release/0.1 Oct 19, 2016
@tedsalmon tedsalmon deleted the bugfix/0.1/fix-sequence branch October 19, 2016 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants