Conversation
.config made using the notmuch module a bit clunky. should be better now
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the notmuch module configuration and introduces a check system for validating modules. The primary change renames the config option to settings in the notmuch module to avoid confusion with the standard NixOS config attribute. The PR also adds infrastructure to automatically discover and run module-level checks.
Key changes:
- Renamed notmuch module's
configoption tosettingsfor clarity - Added check files for notmuch and mpv modules to validate basic functionality
- Updated module loading to use directory-based structure with
module.nixfiles - Extended the flake's checks system to automatically include module-level checks
Reviewed Changes
Copilot reviewed 5 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| modules/notmuch/module.nix | Renamed config option to settings and updated references |
| modules/notmuch/check.nix | Added test to verify notmuch module can be applied and runs successfully |
| modules/mpv/check.nix | Added test to verify mpv module can be applied and runs successfully |
| modules.nix | Updated to load modules from directory structure expecting module.nix files |
| flake.nix | Extended checks to automatically discover and run check.nix files in module directories |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.config made using the notmuch module a bit clunky. should be better now