Skip to content

add module checks & fix notmuch module#10

Merged
Lassulus merged 1 commit intomainfrom
mod_checks
Oct 20, 2025
Merged

add module checks & fix notmuch module#10
Lassulus merged 1 commit intomainfrom
mod_checks

Conversation

@Lassulus
Copy link
Copy Markdown
Owner

.config made using the notmuch module a bit clunky. should be better now

.config made using the notmuch module a bit clunky. should be better now
@Lassulus Lassulus requested a review from Copilot October 20, 2025 17:50
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the notmuch module configuration and introduces a check system for validating modules. The primary change renames the config option to settings in the notmuch module to avoid confusion with the standard NixOS config attribute. The PR also adds infrastructure to automatically discover and run module-level checks.

Key changes:

  • Renamed notmuch module's config option to settings for clarity
  • Added check files for notmuch and mpv modules to validate basic functionality
  • Updated module loading to use directory-based structure with module.nix files
  • Extended the flake's checks system to automatically include module-level checks

Reviewed Changes

Copilot reviewed 5 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
modules/notmuch/module.nix Renamed config option to settings and updated references
modules/notmuch/check.nix Added test to verify notmuch module can be applied and runs successfully
modules/mpv/check.nix Added test to verify mpv module can be applied and runs successfully
modules.nix Updated to load modules from directory structure expecting module.nix files
flake.nix Extended checks to automatically discover and run check.nix files in module directories

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Lassulus Lassulus merged commit 81da0bc into main Oct 20, 2025
2 checks passed
@Lassulus Lassulus deleted the mod_checks branch November 6, 2025 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants