-
Notifications
You must be signed in to change notification settings - Fork 6
Migrate to 0.16.0 #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks a lot for the contribution! I will review this PR after im finished with the teloxide update |
LasterAlex
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work! Just some nitpicks. Other than that i trust the tests. Also, do you have plans on adding 0.17.0? If yes, please say that, it would be bad for us to do the same work twice
| .from(MockUser::new().first_name("me").id(1234).build()); | ||
|
|
||
| let mut bot = MockBot::new(me_message.clone(), handler_tree()); | ||
| bot.dependencies(deps![get_bot_storage().await]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here
|
Thanks! Yeah, I can do 0.17.0 as well. |
|
Ok! Will wait for that, thanks a lot! I will focus on improving teloxide itself then, I have some unresolved problems. |
LasterAlex
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Adapt the crate to the new teloxide version.