Skip to content

Conversation

@magnickolas
Copy link
Contributor

Adapt the crate to the new teloxide version.

@LasterAlex
Copy link
Owner

Thanks a lot for the contribution! I will review this PR after im finished with the teloxide update

Copy link
Owner

@LasterAlex LasterAlex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work! Just some nitpicks. Other than that i trust the tests. Also, do you have plans on adding 0.17.0? If yes, please say that, it would be bad for us to do the same work twice

.from(MockUser::new().first_name("me").id(1234).build());

let mut bot = MockBot::new(me_message.clone(), handler_tree());
bot.dependencies(deps![get_bot_storage().await]);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

@magnickolas
Copy link
Contributor Author

Thanks! Yeah, I can do 0.17.0 as well.

@LasterAlex
Copy link
Owner

Ok! Will wait for that, thanks a lot! I will focus on improving teloxide itself then, I have some unresolved problems.

@LasterAlex LasterAlex self-requested a review July 21, 2025 10:09
Copy link
Owner

@LasterAlex LasterAlex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@LasterAlex LasterAlex merged commit ad02529 into LasterAlex:master Jul 21, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants