Skip to content

Add aria-label for flash dismiss button#521

Merged
chawes13 merged 5 commits intomasterfrom
feature/add-flash-remove-aria-label
Mar 19, 2022
Merged

Add aria-label for flash dismiss button#521
chawes13 merged 5 commits intomasterfrom
feature/add-flash-remove-aria-label

Conversation

@chawes13
Copy link
Copy Markdown
Contributor

@chawes13 chawes13 commented Jan 11, 2022 •
edited
Loading

Resolves #516

Author Checklist

  • Add unit test(s)
  • Update version in package.json (see the versioning guidelines)
  • Update documentation (if necessary)
  • Add story to storybook (if necessary)
  • Assign dev reviewer

@chawes13 chawes13 requested a review from bhennes2 January 11, 2022 15:11
@chawes13
Copy link
Copy Markdown
Contributor Author

chawes13 commented Feb 23, 2022

@bhennes2 bump

bhennes2
bhennes2 approved these changes Feb 23, 2022
View reviewed changes
Copy link
Copy Markdown

@bhennes2 bhennes2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👏

@chawes13 chawes13 merged commit 7674752 into master Mar 19, 2022
@chawes13 chawes13 deleted the feature/add-flash-remove-aria-label branch March 19, 2022 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bhennes2 bhennes2 bhennes2 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

FlashMessage onDismiss button should have an aria-label

2 participants

@chawes13 @bhennes2