fix: feature = ["sgx", "std"] のケースで localstd が二重定義される問題を修正#597
Merged
fix: feature = ["sgx", "std"] のケースで localstd が二重定義される問題を修正#597
feature = ["sgx", "std"] のケースで localstd が二重定義される問題を修正#597Conversation
Contributor
Author
|
(CI通る前にreviewerアサインしてしまったから解除) |
osuketh
approved these changes
May 22, 2021
Member
osuketh
left a comment
There was a problem hiding this comment.
本来、"sgx" と "std" のfeatureを両方指定する挙動は意図していないので、同時に両方指定されないような制限ができると良いかなと思いました。(具体的な方法思いついていない)
このPRは 👍 ですー
Contributor
Author
|
では
このissueに
に関しても記載しておきます 🙋 |
Contributor
Author
|
@osuketh ↓↓のような感じでマージできません 😭 |
Member
|
すません直しました |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Issueへのリンク
(なし)
やったこと
VSCode の Remote Container で dev環境上のコンテナに接続し、rust-analyzer をかけていたところ、たまたまtitleの問題に気づきました。
やらないこと
考えられるfeatureの組み合わせで、CIでマトリクスビルドを書けておくべきだと思います。
今回はやらないですが、このPRが妥当と判断されたらまずはissue化します。
動作検証
rust-analyzer がエラーを吐かなくなった
参考
(なし)