Conversation
laysakura
force-pushed
the
refactor/EnclaveEngine-handle_without_runtime-takes-self
branch
from
cd04468 to
51d09dc
Compare
laysakura
force-pushed
the
refactor/EnclaveEngine-handle_without_runtime-takes-self
branch
from
2b4a8c6 to
1168306
Compare
laysakura
deleted the
refactor/EnclaveEngine-handle_without_runtime-takes-self
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issueへのリンク
（なし）
やったこと
handle()とhandle_without_runtime()が混ざった、使い方に注意が必要なtraitであったBasicEnclaveEngine::handleは self 引数を取り、 ecall_input が取得できるようにしたEnclaveEngine::decryptは実際には復号していないコンストラクタなので、newと改名やらないこと
（なし）
動作検証
コンパイル・テスト通ればOK
参考
これから暗号DBを作るに当たり、enclave_inputを取る & runtimeに依存しないEnclaveEngineが必要だったので、先に作りました。