feat: PJ_ROOT_DIR 環境変数の追加 & PJ_NAME 環境変数の削除#620
Merged
Conversation
06272f3 to
b8cc450
Compare
laysakura
commented
May 27, 2021
| #!/bin/bash | ||
|
|
||
| set -e | ||
| set -ex |
Contributor
Author
There was a problem hiding this comment.
CIが落ちたときにどの箇所かわかりやすくするためにサクッとつけてしまいました。
Contributor
Author
|
https://github.com/LayerXcom/anonify-contracts/search?q=PJ_NAME @osuketh PJ_NAMEも同時に消しちゃおうと話しましたが、やはり併存期間必要そうです。
としようと思います。どうでしょうか? |
Member
|
あー..あざます!そいつで行きましょう 👍 |
ba51d40 to
ec07063
Compare
osuketh
approved these changes
May 27, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issueへのリンク
(なし)
やったこと
CDWが
~/anonify/**にないときに、EnclaveDir::new()で作成されるディレクトリが/.anonify/になりがち(PJ_NAME="anonify"の場合)。CWDに依存せずにEnclaveDirのpathを決定するために、PJ_ROOT_DIR環境変数を追加。
それに伴い、このrepoからは
PJ_NAME環境変数を削除(PJ_ROOT_DIR設定にしか使われていない)。ただし他のrepoでもPJ_NAMEを使っているので、いまは併存期間とし、PJ_ROOT_DIR の決定アルゴリズムをこうする:
やらないこと
(なし)
動作検証
/home/anonify-dev/.pgx/data-13PJ_ROOT_DIR="/home/anonify-dev/"の場合に
EnclaveDir::new()し、/home/anonify-dev/.anonify/ディレクトリができることを確認。参考
(なし)