Skip to content

CI improvements#646

Merged
cipepser merged 14 commits intomainfrom
feature/separate-ci-jobs
Jun 17, 2021
Merged

CI improvements#646
cipepser merged 14 commits intomainfrom
feature/separate-ci-jobs

Conversation

@cipepser
Copy link
Copy Markdown
Collaborator

@cipepser cipepser commented Jun 17, 2021

Issueへのリンク

  • なし

やったこと

  • pgxを通常CIから分離
  • mainマージ時に通常CI、e2e CI、pgx CI追加
  • base-*をbuildするのはDockerfileに変更があった場合のみ
  • base-*の隠蔽をtemplate化
  • SPIDとSUB_KEYは必要なtaskにてenvで設定

やらないこと

  • なし

動作検証

  • CI
  • mainマージは例によって未確認

参考

  • なし

@cipepser cipepser requested a review from osuketh June 17, 2021 07:56
Copy link
Copy Markdown
Member

@osuketh osuketh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@cipepser cipepser requested a review from laysakura June 17, 2021 13:35
Copy link
Copy Markdown
Contributor

@laysakura laysakura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

このPRはOKです!
ただ... なんかCI遅くなりましたね 🤔

この時点のE2E では各イメージのビルドが10~12分くらいですが、

image

いまのE2E は21~23分掛かってる...

image

スポットインスタンスに変えた影響ですかね? 🤔

@cipepser cipepser merged commit f48de16 into main Jun 17, 2021
@cipepser cipepser deleted the feature/separate-ci-jobs branch June 17, 2021 13:48
@laysakura
Copy link
Copy Markdown
Contributor

あるいはRunner VMの計算リソースを並列job間で奪い合ってるか(こっちな気がしてきた)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants