DEVREL-531 rename retryPayload to retryMessage#1690
Merged
Conversation
nazreen
commented
Aug 27, 2025
nazreen
commented
Aug 27, 2025
nazreen
changed the title
ravinagill15
reviewed
Sep 5, 2025
Contributor
ravinagill15
left a comment
ravinagill15
left a comment
There was a problem hiding this comment.
Overall looks good, left a few thoughts/questions
Let's also add a changeset
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR renames the retryPayload task to retryMessage across multiple Solana example projects to improve naming consistency. It also updates parameter names to align with Solana CLI conventions.
- Renamed task from
lz:*:solana:retry-payloadtolz:*:solana:retry-messageacross three example projects - Updated parameter names:
payload→message,computeUnits→withComputeUnitLimit,withPriorityFee→withComputeUnitPrice - Simplified wallet handling by removing manual private key parsing in favor of using the existing
signerfromderiveConnection
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| examples/oft-solana/tasks/solana/retryMessage.ts | Renamed task and parameters, simplified wallet handling |
| examples/oft-solana/tasks/index.ts | Updated import to reflect renamed file |
| examples/oapp-solana/tasks/solana/retryMessage.ts | Renamed task and parameters, simplified wallet handling |
| examples/lzapp-migration/tasks/solana/retryMessage.ts | Renamed task and parameters for consistency |
| .changeset/quick-planets-approve.md | Added changeset for oapp and lzapp migration examples |
| .changeset/gorgeous-kings-grow.md | Added changeset for oft example |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
ravinagill15
approved these changes
Sep 10, 2025
Contributor
ravinagill15
left a comment
ravinagill15
left a comment
There was a problem hiding this comment.
Looks good, just a minor nit on the changeset
Contributor
|
Also just noticed the failing builds, let's ensure they pass before merging |
DanL0
approved these changes
Sep 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
computeUnitstowithComputeUnitLimitandwithPriorityFeetowithComputeUnitPriceto align the param names to how they are in thesolanaCLIProof of Test
https://solscan.io/tx/5QpyGaUtsLGrbZAtuQgYwZhwDrLrjLJNXMLh4STth2yytMSjZhKejXrzt8vNQa5UdQ9uXnhvCZ2TowmTeJhNNrbK?cluster=devnet