fix(build): pass VERSION arg through taskfile build and pack steps#112
Merged
j-d-ha merged 9 commits intoApr 20, 2026
Merged
Conversation
- Fallback to `AssemblyName.Version` when `AssemblyInformationalVersionAttribute` is unavailable. - Default to "unknown" if both values are missing.
- Enhanced regex to match version strings with a "+" suffix, e.g., `1.2.3+buildinfo`. - Adjusted formatting for better readability and maintenance.
- Introduced `VERSION` variable in `taskfile.yaml` for custom build versioning. - Updated `build`, `pack`, and `publish` tasks to include `/p:Version` when `VERSION` is defined. - Enforced `VERSION` requirement for `publish` and `pack-local` tasks.
- Removed fallback to `AssemblyName.Version` when `AssemblyInformationalVersion` is unavailable. - Simplified assignment logic to default directly to "unknown".
- Updated task name for clarity and consistency with its purpose. - No changes to functionality or dependencies.
- Updated `echo` command to display the `VERSION` being published. - Enhances logging clarity during local NuGet publishing.
- Updated `publish-preview.yml` and `publish-release.yml` to reference `main` instead of `v8.0`. - Adjusted `release` event trigger syntax in `publish-release.yml` for consistency. - Ensures workflows use the latest updates from the shared templates.
- Updated `echo` command to display the `VERSION` being published. - Improves logging clarity during NuGet package publishing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
📋 Summary
Adds optional
VERSIONvariable support to thebuildandpackTaskfile tasks, and makes it required forpublishandpublish-local. Also renamespack-local→publish-localfor consistency.task publish VERSION=1.0.0andtask publish-local VERSION=1.0.0enforce the arg viarequirestask buildandtask packwork as before without it —/p:Versionis only injected whenVERSIONis set✅ Checklist
🧪 Related Issues or PRs
💬 Notes for Reviewers
Also includes the generator fix for
AssemblyInformationalVersionfallback (commits0e8f0e3,8af41b3) and a regex fix forGeneratedCodeAttributesnapshot tests (7078962).