punycode imports are broken in 2.0.0-beta

[MrOrz]

Version(s) affected: 2.0.0-beta.5

Description
whoiser 2 beta version is loading the deprecated Node.JS module punycode instead of the one in node_modules

How to reproduce

This breaks things in non-node.js environments, such as Cloudflare's vitest pool workers.

Possible Solution

Follow the instruction in punycode.js to properly load the userland module

import punycode from 'punycode/';

After adding the trailing /, it's correctly pointing to the punycode in node_modules.

Additional context

• whoiser v1 does the import correctly. However I cannot use whoiser v1 because it depends on NodeJS https module, which Cloudflare worker environment does not support at all.

[AndreiIgna]

hey @MrOrz

Could you provide more info about the error please? What error message are you seeing, and which node version are you using?

The import with slash at the end works only in CommonJS with require('punycode/') and doesn't not work with ESM import ...

The current implementation works ok in my case, and the v2 rewrite is done exactly because I'm using whoiser in Cloudflare Workers

[AndreiIgna]

@MrOrz give v2.0.0-beta.6 a try. I've made this change f336331 that seems to fix the punycode import

[MrOrz]

Could you provide more info about the error please? What error message are you seeing, and which node version are you using?

Environment: nodejs v22.14.0

Steps to reproduce

1. checkout a176a4d97246f0f743a5befa44be1c65b3e4c5ca of https://github.com/Open165/worker
2. npm uninstall whoiser (uninstall my own fork) and npm install whoiser@2.0.0-beta.5
3. npm i for the rest of dependencies
4. npm t

Expected: test pass

Actual:

> open165-worker@0.0.0 test
> vitest


 DEV  v3.1.3 open165-worker

[vpw:inf] Starting isolated runtimes for vitest.config.mts...
[vitest-pool-workers] Failed to import "node:punycode" from "open165-worker/node_modules/whoiser/dist/whoiser.js". To resolve this, try bundling the relevant dependency with Vite. For more details, refer to https://developers.cloudflare.com/workers/testing/vitest-integration/known-issues/#module-resolution
workerd/server/server.c++:3198: error: Fallback service failed to fetch module; payload = ; spec = /?specifier=node%3Apunycode&referrer=%2FUsers%2Fmrorz%2Fworkspace%2Fopen165-worker%2Fnode_modules%2Fwhoiser%2Fdist%2Fwhoiser.js&rawSpecifier=node%3Apunycode
[vitest-pool-workers] Failed to import "node:punycode" from "open165-worker/node_modules/whoiser/dist/whoiser.js". To resolve this, try bundling the relevant dependency with Vite. For more details, refer to https://developers.cloudflare.com/workers/testing/vitest-integration/known-issues/#module-resolution
workerd/server/server.c++:3198: error: Fallback service failed to fetch module; payload = ; spec = /?specifier=node%3Apunycode&referrer=%2FUsers%2Fmrorz%2Fworkspace%2Fopen165-worker%2Fnode_modules%2Fwhoiser%2Fdist%2Fwhoiser.js&rawSpecifier=node%3Apunycode
[vitest-pool-workers] Failed to import "node:punycode" from "open165-worker/node_modules/whoiser/dist/whoiser.js". To resolve this, try bundling the relevant dependency with Vite. For more details, refer to https://developers.cloudflare.com/workers/testing/vitest-integration/known-issues/#module-resolution
workerd/server/server.c++:3198: error: Fallback service failed to fetch module; payload = ; spec = /?specifier=node%3Apunycode&referrer=%2FUsers%2Fmrorz%2Fworkspace%2Fopen165-worker%2Fnode_modules%2Fwhoiser%2Fdist%2Fwhoiser.js&rawSpecifier=node%3Apunycode
[vitest-pool-workers] Failed to import "node:punycode" from "open165-worker/node_modules/whoiser/dist/whoiser.js". To resolve this, try bundling the relevant dependency with Vite. For more details, refer to https://developers.cloudflare.com/workers/testing/vitest-integration/known-issues/#module-resolution
workerd/server/server.c++:3198: error: Fallback service failed to fetch module; payload = ; spec = /?specifier=node%3Apunycode&referrer=%2FUsers%2Fmrorz%2Fworkspace%2Fopen165-worker%2Fnode_modules%2Fwhoiser%2Fdist%2Fwhoiser.js&rawSpecifier=node%3Apunycode

⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯ Failed Suites 2 ⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯

 FAIL  test/index.spec.ts [ test/index.spec.ts ]
 FAIL  test/whois.spec.ts [ test/whois.spec.ts ]
Error: No such module "node:punycode".
  imported from "Users/mrorz/workspace/open165-worker/node_modules/whoiser/dist/whoiser.js"
⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯[1/2]⎯


 Test Files  2 failed (2)
      Tests  no tests
   Start at  15:21:18
   Duration  3.40s (transform 146ms, setup 0ms, collect 0ms, tests 0ms, environment 1ms, prepare 942ms)

 FAIL  Tests failed. Watching for file changes...

The repository is bootstrapped by create-cloudflare, and the test is set by Cloudflare to use Cloudflare's vitest-pool-workers.

The error message, Failed to import "node:punycode", indicates that the runtime did not load the userland punycode and tried to reach for the already obsolete punycode module in legacy NodeJS.

[MrOrz]

give v2.0.0-beta.6 a try

Unfortunately it does not fix the issue in my code. Error is the same -- Failed to import "node:punycode", indicating that it's trying to load NodeJS punycode.

Code: https://github.com/Open165/worker/blob/upgrade-whoiser/vitest.config.mts

$ cat node_modules/whoiser/package.json | grep version
        "version": "2.0.0-beta.6",
$ npm t                                               

> open165-worker@0.0.0 test
> vitest


 DEV  v3.1.3 open165-worker

[vpw:inf] Starting isolated runtimes for vitest.config.mts...
[vitest-pool-workers] Failed to import "node:punycode" from "open165-worker/node_modules/whoiser/dist/whoiser.js". To resolve this, try bundling the relevant dependency with Vite. For more details, refer to https://developers.cloudflare.com/workers/testing/vitest-integration/known-issues/#module-resolution
workerd/server/server.c++:3198: error: Fallback service failed to fetch module; payload = ; spec = /?specifier=node%3Apunycode&referrer=open165-worker%2Fnode_modules%2Fwhoiser%2Fdist%2Fwhoiser.js&rawSpecifier=node%3Apunycode
[vitest-pool-workers] Failed to import "node:punycode" from "open165-worker/node_modules/whoiser/dist/whoiser.js". To resolve this, try bundling the relevant dependency with Vite. For more details, refer to https://developers.cloudflare.com/workers/testing/vitest-integration/known-issues/#module-resolution
workerd/server/server.c++:3198: error: Fallback service failed to fetch module; payload = ; spec = /?specifier=node%3Apunycode&referrer=open165-worker%2Fnode_modules%2Fwhoiser%2Fdist%2Fwhoiser.js&rawSpecifier=node%3Apunycode
[vitest-pool-workers] Failed to import "node:punycode" from "open165-worker/node_modules/whoiser/dist/whoiser.js". To resolve this, try bundling the relevant dependency with Vite. For more details, refer to https://developers.cloudflare.com/workers/testing/vitest-integration/known-issues/#module-resolution
workerd/server/server.c++:3198: error: Fallback service failed to fetch module; payload = ; spec = /?specifier=node%3Apunycode&referrer=open165-worker%2Fnode_modules%2Fwhoiser%2Fdist%2Fwhoiser.js&rawSpecifier=node%3Apunycode
[vitest-pool-workers] Failed to import "node:punycode" from "open165-worker/node_modules/whoiser/dist/whoiser.js". To resolve this, try bundling the relevant dependency with Vite. For more details, refer to https://developers.cloudflare.com/workers/testing/vitest-integration/known-issues/#module-resolution
workerd/server/server.c++:3198: error: Fallback service failed to fetch module; payload = ; spec = /?specifier=node%3Apunycode&referrer=open165-worker%2Fnode_modules%2Fwhoiser%2Fdist%2Fwhoiser.js&rawSpecifier=node%3Apunycode

⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯ Failed Suites 2 ⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯

 FAIL  test/index.spec.ts [ test/index.spec.ts ]
 FAIL  test/whois.spec.ts [ test/whois.spec.ts ]
Error: No such module "node:punycode".
  imported from "open165-worker/node_modules/whoiser/dist/whoiser.js"
⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯[1/2]⎯


 Test Files  2 failed (2)
      Tests  no tests
   Start at  15:37:38
   Duration  2.51s (transform 116ms, setup 0ms, collect 0ms, tests 0ms, environment 0ms, prepare 668ms)

 FAIL  Tests failed. Watching for file changes...

[Xubor]

In beta.6 the problem persists. Node.js internal punycode module is still used:

$ node --version
v22.17.0
$ npm list whoiser
project@0.0.0 /some-path/
└── whoiser@2.0.0-beta.6
$ node
> require("whoiser");true;
true;
> (node:1255002) [DEP0040] DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.
(Use `node --trace-deprecation ...` to show where the warning was created)

Easiest solution is to switch to ESM repack of the punycode.js module https://www.npmjs.com/package/punycode-esm