refactor: config loading and add eigen.toml template generation#13
Merged
supernovahs merged 1 commit intomainfrom Apr 24, 2025
Merged
refactor: config loading and add eigen.toml template generation#13supernovahs merged 1 commit intomainfrom
supernovahs merged 1 commit intomainfrom
Conversation
**Motivation:** Project commands generated confusing errors when eigen.toml was missing, especially with help flags and unimplemented commands. **Modifications:** - Removed config loading from global Before hook - Moved config loading to individual commands that need it - Added project-specific eigen.toml generation during project creation - Improved error messages for missing configuration **Result:** Help commands work without eigen.toml, create command properly initializes config, and each command handles its own configuration needs independently, resulting in a more intuitive CLI experience.
ad-eigen
changed the title
supernovahs
approved these changes
Apr 24, 2025
Contributor
supernovahs
left a comment
supernovahs
left a comment
There was a problem hiding this comment.
LGTM . I was also thinking about blocking other cli commands aspect when updating readme
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
Project commands generated confusing errors when eigen.toml was missing, especially with help flags and unimplemented commands.
Modifications:
Result:
Help commands work without eigen.toml, create command properly initializes config, and each command handles its own configuration needs independently, resulting in a more intuitive CLI experience.