Skip to content

docs: small slash amounts #1088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 13, 2025
Merged

docs: small slash amounts #1088

merged 2 commits into from
Feb 13, 2025

Conversation

@0xClandestine
Copy link
Member

@0xClandestine 0xClandestine commented Feb 12, 2025 •
edited
Loading

Motivation:

We weren't documenting that small slashing amounts (wadToSlash) can round down to zero, preventing tokens from being marked for burning. This can result in tokens being permanently locked in the contract instead of burned as intended. (EGSL-13)

Modifications:

  • Added documentation note clarifying that small slashing amounts may not result in actual token burns due to rounding.
  • Ensured transparency in the slashing mechanism to prevent confusion about unburned but locked tokens.

Result:

  • Clearer documentation on rounding behavior in the slashing mechanism.
  • Awareness that very small slashing amounts may not contribute to burnableShares[strategy], avoiding unexpected outcomes.

@0xClandestine 0xClandestine changed the base branch from dev to slashing-magnitudes-fixes February 12, 2025 17:22
@0xClandestine 0xClandestine force-pushed the docs/small-slash-amounts branch from 2669e26 to 1934192 Compare February 13, 2025 14:40
@0xClandestine 0xClandestine added the ⚖️ Audit Fix Audit-related fixes. label Feb 13, 2025
@0xClandestine 0xClandestine force-pushed the docs/small-slash-amounts branch from 9cecdb7 to 4150c42 Compare February 13, 2025 16:06
@ypatil12 ypatil12 merged commit de4e642 into slashing-magnitudes-fixes Feb 13, 2025
11 checks passed
@ypatil12 ypatil12 deleted the docs/small-slash-amounts branch February 13, 2025 16:10
@wadealexc wadealexc mentioned this pull request Feb 18, 2025
Merged
ypatil12 pushed a commit that referenced this pull request Feb 19, 2025
@0xClandestine @wadealexc @ypatil12
docs: small slash amounts (#1088)
42f7d27 
* docs: small slash amounts

* docs: update contract docs

---------

Co-authored-by: wadealexc <pragma-services@proton.me>
ypatil12 pushed a commit that referenced this pull request Feb 20, 2025
@0xClandestine @wadealexc @ypatil12
docs: small slash amounts (#1088)
ae5af85 
* docs: small slash amounts

* docs: update contract docs

---------

Co-authored-by: wadealexc <pragma-services@proton.me>
ypatil12 pushed a commit that referenced this pull request Feb 20, 2025
@0xClandestine @wadealexc @ypatil12
docs: small slash amounts (#1088)
3e4cdb4 
* docs: small slash amounts

* docs: update contract docs

---------

Co-authored-by: wadealexc <pragma-services@proton.me>
ypatil12 pushed a commit that referenced this pull request Feb 20, 2025
@0xClandestine @wadealexc @ypatil12
docs: small slash amounts (#1088)
6397cb5 
* docs: small slash amounts

* docs: update contract docs

---------

Co-authored-by: wadealexc <pragma-services@proton.me>
ypatil12 pushed a commit that referenced this pull request Feb 20, 2025
@0xClandestine @wadealexc @ypatil12
docs: small slash amounts (#1088)
88eb6ef 
* docs: small slash amounts

* docs: update contract docs

---------

Co-authored-by: wadealexc <pragma-services@proton.me>
ypatil12 pushed a commit that referenced this pull request Feb 20, 2025
@0xClandestine @wadealexc @ypatil12
docs: small slash amounts (#1088)
e1dbc16 
* docs: small slash amounts

* docs: update contract docs

---------

Co-authored-by: wadealexc <pragma-services@proton.me>
ypatil12 pushed a commit that referenced this pull request Feb 20, 2025
@0xClandestine @wadealexc @ypatil12
docs: small slash amounts (#1088)
ab47b19 
* docs: small slash amounts

* docs: update contract docs

---------

Co-authored-by: wadealexc <pragma-services@proton.me>
ypatil12 pushed a commit that referenced this pull request Feb 20, 2025
@0xClandestine @wadealexc @ypatil12
docs: small slash amounts (#1088)
6130f9f 
* docs: small slash amounts

* docs: update contract docs

---------

Co-authored-by: wadealexc <pragma-services@proton.me>
ypatil12 pushed a commit that referenced this pull request Feb 20, 2025
@0xClandestine @wadealexc @ypatil12
docs: small slash amounts (#1088)
9402cf3 
* docs: small slash amounts

* docs: update contract docs

---------

Co-authored-by: wadealexc <pragma-services@proton.me>
ypatil12 pushed a commit that referenced this pull request Feb 20, 2025
@0xClandestine @wadealexc @ypatil12
docs: small slash amounts (#1088)
72161b8 
* docs: small slash amounts

* docs: update contract docs

---------

Co-authored-by: wadealexc <pragma-services@proton.me>
ypatil12 pushed a commit that referenced this pull request Feb 20, 2025
@0xClandestine @wadealexc @ypatil12
docs: small slash amounts (#1088)
f83ef25 
* docs: small slash amounts

* docs: update contract docs

---------

Co-authored-by: wadealexc <pragma-services@proton.me>
ypatil12 pushed a commit that referenced this pull request Feb 20, 2025
@0xClandestine @wadealexc @ypatil12
docs: small slash amounts (#1088)
e978d0a 
* docs: small slash amounts

* docs: update contract docs

---------

Co-authored-by: wadealexc <pragma-services@proton.me>
ypatil12 pushed a commit that referenced this pull request Feb 20, 2025
@0xClandestine @wadealexc @ypatil12
docs: small slash amounts (#1088)
ce03e64 
* docs: small slash amounts

* docs: update contract docs

---------

Co-authored-by: wadealexc <pragma-services@proton.me>
ypatil12 pushed a commit that referenced this pull request Feb 20, 2025
@0xClandestine @wadealexc @ypatil12
docs: small slash amounts (#1088)
b874648 
* docs: small slash amounts

* docs: update contract docs

---------

Co-authored-by: wadealexc <pragma-services@proton.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ypatil12 ypatil12 ypatil12 approved these changes

@eigenmikem eigenmikem eigenmikem approved these changes

+1 more reviewer

@wadealexc wadealexc wadealexc approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

⚖️ Audit Fix Audit-related fixes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@0xClandestine @wadealexc @ypatil12 @eigenmikem