Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds a new release.yml GitHub Actions workflow for building and publishing signed APKs as draft GitHub releases on version tag pushes (vX.Y.Z), while disabling three existing workflows (agent, auxiliary, periodic-restart) by commenting them out.
Changes:
- Added
release.ymlworkflow: validates tag format, sets up Java 17 + Flutter, decodes an upload keystore from secrets, builds a signed release APK, generates release notes from git history, and creates a draft GitHub release. - Commented out the
agent.yml,auxiliary.yml, andperiodic-restart.ymlworkflows to disable build/deploy and periodic restart operations.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
.github/workflows/release.yml |
New workflow for building signed APKs and creating draft GitHub releases on tag pushes |
.github/workflows/agent.yml |
Entire workflow commented out to disable agent build/deploy |
.github/workflows/auxiliary.yml |
Entire workflow commented out to disable auxiliary build/deploy |
.github/workflows/periodic-restart.yml |
Entire workflow commented out to disable periodic agent restarts |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
| java-version: 17 | ||
|
|
||
| - name: Set up Flutter | ||
| uses: subosito/flutter-action@v2 |
.github/workflows/release.yml
Outdated
Comment on lines
+63
to
+68
| if [ -z "$PREVIOUS_TAG" ]; then | ||
| echo "notes=Initial release 🎉" >> "$GITHUB_OUTPUT" | ||
| else | ||
| NOTES=$(git log --pretty=format:"- %s (%h)" "$PREVIOUS_TAG"..HEAD -- ':!.github') | ||
| # Escape for GitHub Actions multiline output | ||
| EOF=$(dd if=/dev/urandom bs=15 count=1 status=none | base64) |
Comment on lines
+1
to
+87
| #name: Build and Deploy Agent | ||
| # | ||
| #on: | ||
| # push: | ||
| # paths: | ||
| # - "agent/**" | ||
| # branches: | ||
| # - main | ||
| # pull_request: | ||
| # paths: | ||
| # - "agent/**" | ||
| # branches: | ||
| # - 'main' | ||
| # workflow_dispatch: | ||
| # | ||
| #jobs: | ||
| # build: | ||
| # runs-on: ubuntu-latest | ||
| # permissions: | ||
| # contents: read | ||
| # packages: write | ||
| # | ||
| # steps: | ||
| # - name: Checkout repository | ||
| # uses: actions/checkout@v4 | ||
| # | ||
| # - name: Set up Docker Buildx | ||
| # uses: docker/setup-buildx-action@v1 | ||
| # | ||
| # - name: Log in to the Container registry | ||
| # uses: docker/login-action@v1 | ||
| # with: | ||
| # registry: ghcr.io | ||
| # username: ${{ github.actor }} | ||
| # password: ${{ secrets.GITHUB_TOKEN }} | ||
| # | ||
| # - name: Extract metadata (tags, labels) for Docker | ||
| # id: meta | ||
| # uses: docker/metadata-action@v3 | ||
| # with: | ||
| # images: ghcr.io/muxable/rtchat-agent | ||
| # tags: | | ||
| # type=ref,event=branch | ||
| # type=ref,event=pr | ||
| # type=semver,pattern={{version}} | ||
| # type=semver,pattern={{major}}.{{minor}} | ||
| # | ||
| # - name: Build and push Docker image | ||
| # uses: docker/build-push-action@v2 | ||
| # with: | ||
| # context: ./agent | ||
| # push: true | ||
| # tags: ${{ steps.meta.outputs.tags }} | ||
| # labels: ${{ steps.meta.outputs.labels }} | ||
| # cache-from: type=gha | ||
| # cache-to: type=gha,mode=max | ||
| # | ||
| # deploy: | ||
| # if: github.ref == 'refs/heads/main' | ||
| # runs-on: ubuntu-latest | ||
| # permissions: | ||
| # id-token: write | ||
| # contents: read | ||
| # needs: build | ||
| # concurrency: | ||
| # group: deploy | ||
| # cancel-in-progress: true | ||
| # environment: | ||
| # name: agent | ||
| # url: https://console.cloud.google.com/compute/instanceGroups/details/us-central1-c/agent-small-us-central1?project=rtchat-47692 | ||
| # | ||
| # steps: | ||
| # - name: Checkout repository | ||
| # uses: actions/checkout@v4 | ||
| # | ||
| # - uses: google-github-actions/auth@v1 | ||
| # with: | ||
| # workload_identity_provider: 'projects/832669896677/locations/global/workloadIdentityPools/github-actions/providers/github-actions' | ||
| # service_account: 'github-action-356868763@rtchat-47692.iam.gserviceaccount.com' | ||
| # | ||
| # - name: Set up Cloud SDK | ||
| # uses: google-github-actions/setup-gcloud@v0 | ||
| # | ||
| # - name: Deploy to GCE | ||
| # id: deploy | ||
| # run: | | ||
| # gcloud compute instance-groups managed rolling-action start-update agent-small-us-central1 --project=rtchat-47692 --type='proactive' --max-surge=1 --max-unavailable=1 --minimal-action='replace' --replacement-method='substitute' --version=template=https://www.googleapis.com/compute/beta/projects/rtchat-47692/global/instanceTemplates/agent-e2-small --zone=us-central1-c |
Commented out the agent, auxiliary, and periodic-restart GitHub Actions workflows (effectively disabling build/deploy and periodic restarts). Added a new release.yml workflow that triggers on tag pushes (vX.Y.Z), validates tag format, sets up Java and Flutter, decodes the upload keystore, builds a signed APK, renames the artifact, generates release notes from the previous tag, and creates a draft GitHub release with the APK attached (marks prereleases when the tag contains a hyphen).
LeMyst
force-pushed
the
rework-workflows
branch
from
d9d0d81 to
61ba1d7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commented out the agent, auxiliary, and periodic-restart GitHub Actions workflows (effectively disabling build/deploy and periodic restarts). Added a new release.yml workflow that triggers on tag pushes (vX.Y.Z), validates tag format, sets up Java and Flutter, decodes the upload keystore, builds a signed APK, renames the artifact, generates release notes from the previous tag, and creates a draft GitHub release with the APK attached (marks prereleases when the tag contains a hyphen).