fix: resolve issues #120, #121, #122, #123 (Stellar Wave)#180
Merged
BigBen-7 merged 1 commit intoLead-Studios:mainfrom Mar 28, 2026
Merged
Conversation
, Lead-Studios#123 (Stellar Wave) - Lead-Studios#121: remove module-level Settings() instantiation; all callers now use get_settings() - Lead-Studios#122: make SERVICE_API_KEY and ADMIN_API_KEY required with field_validator enforcing min 32 chars and rejecting known defaults; update .env.example - Lead-Studios#123: implement _query_transfer_stats and _query_invalid_scans with real DB queries against ticket_transfers and invalid_attempts tables - Lead-Studios#120: initialise session=None before try block in _update_analytics_stats and guard rollback/close with `if session:` Closes Lead-Studios#120 Closes Lead-Studios#121 Closes Lead-Studios#122 Closes Lead-Studios#123
|
@Tinna23 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
BigBen-7
approved these changes
Mar 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Settingsclass definition and module-level instantiation in config.py #121: remove module-level Settings() instantiation; all callers now use get_settings()SERVICE_API_KEYandADMIN_API_KEYhave insecure hardcoded defaults in Settings #122: make SERVICE_API_KEY and ADMIN_API_KEY required with field_validator enforcing min 32 chars and rejecting known defaults; update .env.example_query_transfer_statsand_query_invalid_scansin report_service return hardcoded zeros #123: implement _query_transfer_stats and _query_invalid_scans with real DB queries against ticket_transfers and invalid_attempts tablessessionvariable in AnalyticsService exception handlers #120: initialise session=None before try block in _update_analytics_stats and guard rollback/close withif session:Closes #120
Closes #121
Closes #122
Closes #123
Checklist
docs/api-reference.md,docs/etl-pipeline.md)black,isort, andmypypass locally