feat: fix MySQL +8.0 information_schema changes#2
Merged
LeadcodeDev merged 1 commit intoLeadcodeDev:mainfrom May 3, 2026
Merged
feat: fix MySQL +8.0 information_schema changes#2LeadcodeDev merged 1 commit intoLeadcodeDev:mainfrom
LeadcodeDev merged 1 commit intoLeadcodeDev:mainfrom
Conversation
LeadcodeDev
approved these changes
May 3, 2026
Owner
|
Thank you for your contribution and for the email received 👀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MySQL's
information_schemain >=8.0 likely changed how the data from the table is transferred over the wire. Here I use String::from_utf8 to attempt to manually convert the tuples in each row of the "fetch_tables" function in mysql.rs. I was getting the error below while using the script:this implies that the previously used (String, String...) tuple converting each row in the result set was trying to convert a
VARBINARYon the wire to aString, which is unexpected.I think this solution might be more generalized and useful for different MySQL versions, only issue however is that I am not sure what MySQL uses for encoding of its internal tables and schemas, but this worked for me.
Previously it was successfully running the script, but generating no tables:
This is because of another issue with the MySQL usage where it uses the
args.db.schemaarray, but it is default to an array of["public"]and not using the schema defined in the database URL, requiring you to use the--schemasargument instead with no schema defined in the--database-urlargument.