Fix Prism cross-version compat and spec portability#20
Merged
LeahArmstrong merged 1 commit intomainfrom Feb 28, 2026
Merged
Conversation
Add prism_else_clause() helper using respond_to? for Prism <1.0 and >=1.0 API differences (consequent vs else_clause vs subsequent). Use respond_to?-guarded name access on ConstantPathNode for versions where .name was renamed to .child.name. Replace File.chmod(0o000) with File.read stub in view template spec for root/CI environments where chmod has no effect. Add missing require 'pathname' in shared extractor context.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
prism_else_clause()helper withrespond_to?guards for Prism <1.0 / >=1.0 API differences (consequent vs else_clause vs subsequent)ConstantPathNodename access for Prism versions where.namewas renamed to.child.nameFile.chmod(0o000)withFile.readstub in view template spec (chmod has no effect under root/CI)require 'pathname'in shared extractor contextExtracted from PRs #18 and #19 which both carried identical copies of these fixes. Merging this first eliminates the conflict.
Test plan