Skip to content

Only use valid pastKeyValues when sequence length is greater than 0#79

Merged
LeanBitLab merged 1 commit into
mainfrom
fix-proofread-service-pkv-6163460110815717061
Apr 27, 2026
Merged

Only use valid pastKeyValues when sequence length is greater than 0#79
LeanBitLab merged 1 commit into
mainfrom
fix-proofread-service-pkv-6163460110815717061

Conversation

@LeanBitLab
Copy link
Copy Markdown
Owner

  • Updated ProofreadService to properly validate the sequence length of pastKeyValues tensors before trying to pass the cached state to ONNX Runtime.
  • Only sets input tokens and caches when isValidPkv correctly identifies valid sequence length.
  • Updated fallback logic to generate zero tensors for any step if the cache evaluates to invalid.

PR created automatically by Jules for task 6163460110815717061 started by @LeanBitLab

@google-labs-jules
Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@LeanBitLab LeanBitLab merged commit 00e1646 into main Apr 27, 2026
@LeanBitLab LeanBitLab deleted the fix-proofread-service-pkv-6163460110815717061 branch April 27, 2026 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant