ux(settings): clarify Savings Plans card covers SageMaker + Lambda (#22)#53
Conversation
The "Compute Savings Plans" card in Settings → Purchasing actually governs defaults for all four SavingsPlansType values fetched by providers/aws/recommendations/parser_sp.go: ComputeSp (covers EC2, Fargate, Lambda), Ec2InstanceSp, SagemakerSp, and DatabaseSp. Users reported SageMaker and Lambda looked unrepresented in settings. Rename the card header to "Savings Plans" and add a small hint line listing the covered services, so the coverage is self-documenting. No extra cards are added: a Lambda-specific card would be misleading (Lambda SPs do not exist as a standalone product — Lambda usage is covered by Compute SP), and SageMaker SPs share the same term/payment knobs as the other types. The underlying aws-savingsplans-term and aws-savingsplans-payment inputs keep the same IDs so settings wiring and the existing save/load paths are unchanged.
|
@coderabbitai review |
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 45 minutes and 7 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✅ Actions performedReview triggered.
|
|
AWS Sanity (Read-only Dry Run) passed on commit 00e7ae4. All checks green. |
|
Azure Sanity (Read-only Dry Run) passed on commit |
Summary
Closes #22.
The "Compute Savings Plans" card in Settings → Purchasing actually drives defaults for all four Savings Plans types that
providers/aws/recommendations/parser_sp.gofetches on every collection:ComputeSp— covers EC2, Fargate, LambdaEc2InstanceSp— specific EC2 instance familiesSagemakerSp— SageMakerDatabaseSp— RDSAll four share the same term/payment vocabulary at the AWS API, so the UI intentionally exposes a single card rather than four near-identical rows. The old header "Compute Savings Plans" made that invisible to the reporter, who reasonably concluded SageMaker and Lambda had no purchasing defaults.
Change
.service-default-hintCSS rule instyles/settings.css.Why not separate Lambda / SageMaker cards (as the issue originally proposed):
ServiceConfigplumbing, a DB migration, and scheduler/UI changes — out of scope for a documentation fix and unwarranted without evidence users have divergent preferences per plan type.IDs
aws-savingsplans-termandaws-savingsplans-paymentare preserved, sosettings.tswiring and the existing save/load paths are unchanged.Test plan
npm run build(frontend) — clean webpack production buildnpm test(frontend) — 1242/1242 tests pass across 35 suitessettings.tswiring,settings.test.tscoverage, and the save/reset bar continue to work.service-default-card .service-default-hintso it can't bleed into other cardsScreenshot
(Text-only label tweak; the new hint renders as a single muted subtitle line immediately under the card title, above the Term/Payment selects.)