Skip to content

chore(pre-commit): drop stale terraform_validate exclusion (closes #371)#851

Open
cristim wants to merge 1 commit into
feat/multicloud-web-frontendfrom
fix/371-wave15
Open

chore(pre-commit): drop stale terraform_validate exclusion (closes #371)#851
cristim wants to merge 1 commit into
feat/multicloud-web-frontendfrom
fix/371-wave15

Conversation

@cristim
Copy link
Copy Markdown
Member

@cristim cristim commented May 28, 2026

Summary

Test plan

  • terraform validate passes on terraform/modules/compute/azure/cleanup-function/ after terraform init
  • terraform validate passes on terraform/modules/registry/azure/ after terraform init
  • Neither module path appears in any failure output from pre-commit run terraform_validate --all-files
  • CI pre-commit job stays green on this PR

Summary by CodeRabbit

  • Chores
    • Updated pre-commit validation configuration to include previously excluded Terraform modules in validation checks.

Review Change Stack

PR #154 fixed the dynamic-around-scalar HCL bugs in both orphan Azure
modules. Both validate clean now; the exclude block is dead config.
@cristim cristim added triaged Item has been triaged priority/p3 Polish / idea / may never ship severity/low Minor harm urgency/eventually No deadline impact/internal Team-internal only effort/xs Trivial / one-liner type/chore Maintenance / non-user-visible labels May 28, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 28, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 68c9d118-ca85-4605-8667-2c5e728a7d46

📥 Commits

Reviewing files that changed from the base of the PR and between 4956d66 and 037c188.

📒 Files selected for processing (1)
  • .pre-commit-config.yaml
💤 Files with no reviewable changes (1)
  • .pre-commit-config.yaml

📝 Walkthrough

Walkthrough

The .pre-commit-config.yaml file is updated to remove an exclusion rule from the terraform_validate hook. This exclusion previously bypassed validation of specific orphan Terraform modules that contained invalid HCL. With this change, those modules will now be validated during pre-commit checks.

Changes

Pre-commit terraform validation

Layer / File(s) Summary
terraform_validate exclusion removal
.pre-commit-config.yaml
The exclude regex pattern blocking validation of specific orphan Terraform module directories is removed, allowing those modules to be validated.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related issues

Possibly related PRs

  • LeanerCloud/CUDly#697: The retrieved PR's pre-commit workflow skips terraform_validate, which directly affects whether the newly-enabled validation hook runs in CI.

  • LeanerCloud/CUDly#154: Fixes the invalid HCL syntax (dynamic blocks around scalar attributes) in the orphan modules that this PR now enables validation for.

Poem

🐰 Validation hops and bounds once more,
No more exclusions to ignore,
Orphan modules come to light,
Fixed HCL burning bright,
Pre-commit checks now full and true!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: removing a stale exclusion rule from the terraform_validate hook in the pre-commit configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/371-wave15

Comment @coderabbitai help to get the list of available commands and usage tips.

@cristim
Copy link
Copy Markdown
Member Author

cristim commented May 28, 2026

@coderabbitai review

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 28, 2026

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@cristim
Copy link
Copy Markdown
Member Author

cristim commented May 30, 2026

@coderabbitai full review

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 30, 2026

✅ Actions performed

Full review triggered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

effort/xs Trivial / one-liner impact/internal Team-internal only priority/p3 Polish / idea / may never ship severity/low Minor harm triaged Item has been triaged type/chore Maintenance / non-user-visible urgency/eventually No deadline

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant