Skip to content

fix(db): renumber duplicate migration 000057_cleanup_universal_plans to 000060 (closes #970)#971

Merged
cristim merged 1 commit into
feat/multicloud-web-frontendfrom
fix/970-dup-migration-000057
Jun 5, 2026
Merged

fix(db): renumber duplicate migration 000057_cleanup_universal_plans to 000060 (closes #970)#971
cristim merged 1 commit into
feat/multicloud-web-frontendfrom
fix/970-dup-migration-000057

Conversation

@cristim
Copy link
Copy Markdown
Member

@cristim cristim commented Jun 5, 2026

Summary

  • Two migrations shared version 000057: 000057_drop_user_role_to_groups (already applied on live DBs) and 000057_cleanup_universal_plans (merged via ops(plans): migration to clean up universal plans (closes #742) #802, not yet applied). golang-migrate requires unique version numbers and will refuse to run with a collision.
  • Renumbers cleanup_universal_plans from 000057 to 000060 (a free slot between 000059 and 000063) via git mv on all three files (.up.sql, .down.sql, _test.go).
  • Updates version references in SQL comments and test assertions. 000057_drop_user_role_to_groups is untouched.

Test plan

  • pre-commit run check-migration-conflicts --all-files passes (no duplicate)
  • gofmt -l clean on renamed test file
  • go vet ./internal/database/... ./internal/config/... no issues
  • go build ./... succeeds
  • go test ./internal/database/... ./internal/config/... -count=1 731 tests pass

Closes #970

…to 000060 (closes #970)

Two migrations shared version 000057: drop_user_role_to_groups (applied on
live DBs) and cleanup_universal_plans (from #802, not yet applied). golang-
migrate requires unique version numbers. Renumber cleanup_universal_plans to
000060 (a free slot between 000059 and 000063), and update the version
references in its SQL comments and test file.
@cristim cristim added triaged Item has been triaged priority/p1 Next up; this sprint severity/high Significant harm urgency/now Drop other things impact/all-users Affects every user effort/s Hours type/bug Defect labels Jun 5, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 5, 2026

Warning

Review limit reached

@cristim, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 7 minutes and 30 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: d60c8f96-b4fb-4a4a-9b50-680f39aa7f80

📥 Commits

Reviewing files that changed from the base of the PR and between 69b857a and f253203.

📒 Files selected for processing (3)
  • internal/database/postgres/migrations/000060_cleanup_universal_plans.down.sql
  • internal/database/postgres/migrations/000060_cleanup_universal_plans.up.sql
  • internal/database/postgres/migrations/000060_cleanup_universal_plans_test.go
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/970-dup-migration-000057

Comment @coderabbitai help to get the list of available commands and usage tips.

@cristim
Copy link
Copy Markdown
Member Author

cristim commented Jun 5, 2026

@coderabbitai review

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 5, 2026

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@cristim cristim merged commit fb79f4d into feat/multicloud-web-frontend Jun 5, 2026
3 of 4 checks passed
@cristim cristim deleted the fix/970-dup-migration-000057 branch June 5, 2026 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

effort/s Hours impact/all-users Affects every user priority/p1 Next up; this sprint severity/high Significant harm triaged Item has been triaged type/bug Defect urgency/now Drop other things

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant