fix: do not crash when server variable response contains unknown fields#45
Merged
fix: do not crash when server variable response contains unknown fields#45
Conversation
gyoshev
force-pushed
the
ISOM-2898/fix-variables-merge
branch
from
77a6276 to
8eb3636
Compare
iignatov
approved these changes
Feb 26, 2020
gyoshev
force-pushed
the
ISOM-2898/fix-variables-merge
branch
from
a410415 to
a3b1d26
Compare
|
Any ETA on when this will be released? |
gyoshev
changed the title
Contributor
Author
|
@albacoretuna we are focusing on improving our testing process and aim for a release in about two weeks time. I'll post in this thread once the release is out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Fixes #22
When merging variable dictionaries, VarCache throws an error when the server variables are missing on the client.
Testing strategy