chore: refactor PushManager class

dist/leanplum.d.ts

@@ -93,7 +93,7 @@ export default class Leanplum {
       * Unregisters the browser form web push.
       * @return {Promise}            Resolves on success, otherwise rejects.
       */
-    static unregisterFromWebPush(): Promise<string>;
+    static unregisterFromWebPush(): Promise<void>;
     /**
       * Clears cached values for messages, variables and test assignments.
       * Use sparingly as if the app is updated, you'll have to deal with potentially

src/Leanplum.ts

@@ -443,25 +443,23 @@ Use "npm update leanplum-sdk" or go to https://docs.leanplum.com/reference#javas
    *                                     otherwise fails.
    */
   static registerForWebPush(serviceWorkerUrl?: string): Promise<boolean> {
-    return new Promise((resolve, reject) => {
     if (Leanplum._pushManager.isWebPushSupported()) {
-        return Leanplum._pushManager.register(serviceWorkerUrl, (isSubscribed) => {
-          if (isSubscribed) {
-            return resolve(true)
-          }
-          return Leanplum._pushManager.subscribeUser()
-        })
-      } else {
-        return reject('Leanplum: WebPush is not supported.')
-      }
-    })
+      return Leanplum._pushManager.register(serviceWorkerUrl, (isSubscribed) => {
+        if (isSubscribed) {
+          return Promise.resolve(true)
+        }
+        return Leanplum._pushManager.subscribeUser()
+      })
+    } else {
+      return Promise.reject('Leanplum: WebPush is not supported.')
+    }
   }
 
   /**
    * Unregisters the browser form web push.
    * @return {Promise}            Resolves on success, otherwise rejects.
    */
-  static unregisterFromWebPush(): Promise<string> {
+  static unregisterFromWebPush(): Promise<void> {
     return Leanplum._pushManager.unsubscribeUser()
   }
 

src/LeanplumSocket.ts

@@ -19,8 +19,8 @@
 import isEqual from 'lodash/isEqual'
 import ArgsBuilder from './ArgsBuilder'
 import Constants from './Constants'
-import LeanplumRequest from './LeanplumRequest'
 import SocketIoClient from './SocketIoClient'
+import { CreateRequestFunction } from './types'
 import VarCache from './VarCache'
 
 export default class LeanplumSocket {
@@ -29,7 +29,7 @@ export default class LeanplumSocket {
   public connect(
     cache: VarCache,
     auth: { appId: string, deviceId: string },
-    createRequest: (action: string, args: ArgsBuilder, options: any) => void,
+    createRequest: CreateRequestFunction,
     getLastResponse: (response: any) => any
   ): void {
     if (!WebSocket) {