small edit to OOP #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
darrell24015
left a comment
darrell24015
left a comment
There was a problem hiding this comment.
Nice improvement. I like replacing concatenated strings with the new f-strings.
Contributor
|
Using __str__ is a perfect example. I'll try and include a description in the associated Blog to this repository. At the Aug 19th PyROA meeting, some other "dunders" came up in discussion and would be a great topic for a future meeting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've made a small edit to the
Roomclass in the OOP version of the code.Previously, there was a
get_descriptionfunction, which I've changed to use__str__. This is a so-called "magic method" in Python. They come with classes and can be overridden. The__str__method defines how the object will print using theprintcommand. I have changedmainfor this also.Not necessary, but just a note on something you can do with Python!