UI auf konsistente Angular-21-Basis migrieren und Build-/Runtime-Brüche beheben#487
Merged
Merged
Conversation
Agent-Logs-Url: https://github.com/LearningHouseService/learninghouse/sessions/3748ec52-a045-4e41-a561-8202932dfbdd Co-authored-by: DerOetzi <2345662+DerOetzi@users.noreply.github.com>
Agent-Logs-Url: https://github.com/LearningHouseService/learninghouse/sessions/3748ec52-a045-4e41-a561-8202932dfbdd Co-authored-by: DerOetzi <2345662+DerOetzi@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
DerOetzi
May 11, 2026 09:58
View session
Agent-Logs-Url: https://github.com/LearningHouseService/learninghouse/sessions/2a14e06b-f4c3-4d68-8512-e8595f063ff2 Co-authored-by: DerOetzi <2345662+DerOetzi@users.noreply.github.com>
Agent-Logs-Url: https://github.com/LearningHouseService/learninghouse/sessions/2a14e06b-f4c3-4d68-8512-e8595f063ff2 Co-authored-by: DerOetzi <2345662+DerOetzi@users.noreply.github.com>
DerOetzi
requested changes
May 11, 2026
Agent-Logs-Url: https://github.com/LearningHouseService/learninghouse/sessions/625c6002-8cd9-444a-b29d-ac2511e1f590 Co-authored-by: DerOetzi <2345662+DerOetzi@users.noreply.github.com>
Agent-Logs-Url: https://github.com/LearningHouseService/learninghouse/sessions/b94fe940-fefb-4e73-9cec-76a1a8616e68 Co-authored-by: DerOetzi <2345662+DerOetzi@users.noreply.github.com>
DerOetzi
approved these changes
May 11, 2026
There was a problem hiding this comment.
Pull request overview
Diese PR migriert die UI auf eine konsistente Angular‑21 Basis und behebt dadurch Build-/Runtime-Probleme entlang der UI→Core-Paketierung (GitHub Actions Artifact → Python Package Build).
Changes:
- Upgrade der UI Dependencies auf Angular 21 (inkl. TypeScript/zone.js/ngx-translate) und Anpassung der Angular-Builder-Konfiguration auf
@angular-devkit/build-angular:application. - Anpassung der CI (Node-Version + Artifact-Pfad) an die neue Angular-Outputstruktur (
dist/.../browser/**) für denbuild-coreJob. - Kompatibilitätsanpassungen im UI-Code/Tests (u.a. explizit
standalone: false, TestBed-Imports/Schemas) für erfolgreiche Unit-Tests unter Angular 21.
Reviewed changes
Copilot reviewed 41 out of 42 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| ui/tsconfig.json | Umstellung der TS Module-Auflösung auf bundler für Angular/TS 5.9 Setup. |
| ui/src/main.ts | Entfernt enableProdMode/environment-Branch; belässt Bootstrap via platformBrowserDynamic. |
| ui/src/app/shared/components/yes-no/yes-no.component.ts | Setzt standalone: false explizit. |
| ui/src/app/shared/components/table/table.component.ts | Setzt standalone: false explizit. |
| ui/src/app/shared/components/table/delete-dialog/delete-dialog.component.ts | Setzt standalone: false explizit. |
| ui/src/app/shared/components/session-timer/session-timer.component.ts | Setzt standalone: false explizit. |
| ui/src/app/shared/components/session-timer/session-timer.component.spec.ts | Ergänzt TestBed-Imports/Schemas (CommonModule/Translate/NO_ERRORS_SCHEMA). |
| ui/src/app/shared/components/select/select.component.ts | Setzt standalone: false explizit. |
| ui/src/app/shared/components/password/password.component.ts | Setzt standalone: false explizit. |
| ui/src/app/shared/components/input/input.component.ts | Setzt standalone: false explizit. |
| ui/src/app/shared/components/form-response/form-response.component.ts | Setzt standalone: false explizit. |
| ui/src/app/shared/components/edit-dialog/edit-dialog.component.ts | Setzt standalone: false explizit. |
| ui/src/app/shared/components/button-group/button-group.component.ts | Setzt standalone: false explizit. |
| ui/src/app/shared/components/button-group/button-group.component.spec.ts | Ergänzt TestBed-Imports/Provider-Stubs/Schemas für Angular 21. |
| ui/src/app/shared/components/alert/alert.component.ts | Setzt standalone: false explizit. |
| ui/src/app/shared/components/alert/alert.component.spec.ts | Ergänzt NO_ERRORS_SCHEMA für robustes Template-Compiling. |
| ui/src/app/modules/layout/components/toolbar/toolbar.component.ts | Setzt standalone: false explizit. |
| ui/src/app/modules/layout/components/toolbar/toolbar.component.spec.ts | Ergänzt TestBed-Imports/Provider-Stubs/Schemas. |
| ui/src/app/modules/layout/components/sidenav/sidenav.component.ts | Setzt standalone: false explizit. |
| ui/src/app/modules/layout/components/sidenav/sidenav.component.spec.ts | Ergänzt TestBed-Imports/Provider-Stubs/Schemas. |
| ui/src/app/modules/layout/components/info-dialog/info-dialog.component.ts | Setzt standalone: false explizit. |
| ui/src/app/modules/configuration/pages/sensors/sensors.component.ts | Setzt standalone: false explizit. |
| ui/src/app/modules/configuration/pages/sensors/add-edit-sensor-dialog/add-edit-sensor-dialog.component.ts | Setzt standalone: false explizit. |
| ui/src/app/modules/configuration/pages/sensors/add-edit-sensor-dialog/add-edit-sensor-dialog.component.spec.ts | Ergänzt TestBed-Imports/Provider-Stubs/Schemas. |
| ui/src/app/modules/brains/pages/training/training.component.ts | Setzt standalone: false explizit. |
| ui/src/app/modules/brains/pages/training/training.component.spec.ts | Ergänzt TestBed-Imports/ActivatedRoute-Stub/Schemas. |
| ui/src/app/modules/brains/pages/prediction/prediction.component.ts | Setzt standalone: false explizit. |
| ui/src/app/modules/brains/pages/brains/brains.component.ts | Setzt standalone: false explizit. |
| ui/src/app/modules/brains/pages/brains/add-edit-brain-dialog/add-edit-brain-dialog.component.ts | Setzt standalone: false explizit. |
| ui/src/app/modules/brains/pages/brains/add-edit-brain-dialog/add-edit-brain-dialog.component.spec.ts | Ergänzt TestBed-Imports/Provider-Stubs/Schemas. |
| ui/src/app/modules/brains/components/braininfo/braininfo.component.ts | Setzt standalone: false explizit. |
| ui/src/app/modules/brains/components/braininfo/braininfo.component.spec.ts | Ergänzt TestBed-Imports/Schemas. |
| ui/src/app/modules/auth/pages/login/login.component.ts | Setzt standalone: false explizit. |
| ui/src/app/modules/auth/pages/change-password/change-password.component.ts | Setzt standalone: false explizit. |
| ui/src/app/modules/auth/pages/apikeys/apikeys.component.ts | Setzt standalone: false explizit. |
| ui/src/app/modules/auth/pages/apikeys/add-apikey-dialog/add-apikey-dialog.component.ts | Setzt standalone: false explizit. |
| ui/src/app/app.component.ts | Setzt standalone: false explizit. |
| ui/src/app/app.component.spec.ts | Ergänzt Provider-Stubs (AuthService/MatIconRegistry/DomSanitizer) + Translate + Schema. |
| ui/package.json | Upgrade auf Angular 21 + Updates für ngx-translate/zone.js/typescript + karma reporter. |
| ui/package-lock.json | Lockfile-Update passend zu Angular 21 Dependency-Graph. |
| ui/angular.json | Wechsel auf :application Builder + Umstellung main→browser + Polyfills als Array. |
| .github/workflows/build_project.yml | Node 24 für UI-Build + Artifact-Pfad auf ui/dist/learninghouse/browser/** angepasst. |
Files not reviewed (1)
- ui/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
build-core-Job lokal reproduzieren (UI-Artefakt +python -m build)/home/runner/work/learninghouse/learninghouse/.github/workflows/build_project.ymlauf Angular-21-Outputstruktur korrigieren