Actor and Activity APIs return errors

[paulnebel]

I've been querying the Actor and Activity APIs for my instance of Learning Locker and seem to be getting back some unexpected errors.

I though at first that I'd constructed the queries incorrectly, but I've studied the spec and I've also looked at how a test tool provided by ADL works and I have confirmed that I'm not making any mistakes. As a final test I set up a free Rustici Scorm Cloud account so that I could compare what I get back from that to what I get back from Learning Locker. Here are the results (rest assured that the actor and activity IDs I'm using exist in the respective systems - I'm not looking for something that isn't there!):

• Agent API
  • Rustici Scorm Cloud
    • request: {my Scorm Cloud Endpoint}/agents?agent={"name":"Joe Bloggs","mbox":"mailto:joe@bloggs.com","objectType":"Agent"}
    • response: {"name":["Joe Bloggs"],"mbox":["mailto:joe@bloggs.com"],"objectType":"Person"} - _CORRECT_
  • Learning Locker
    • request: {my Learning Locker Endpoint}/agents?agent={"name":"Joe Bloggs","mbox":"mailto:joe@bloggs.com","objectType":"Agent"}
    • response:
      {
      error: true
      message: "Required parameter is missing - profileId"
      code: 500
      trace: "#0 /var/www/learninglocker/app/controllers/xapi/DocumentController.php(30): Controllers\xAPI\DocumentController->checkParams(Array, Array, Array) Remove all the hardcoded analytics / reporting #1
      .... (more stack trace)
      } - _INCORRECT_ This does not conform to the xAPI spec. There is no requirement for a profileId parameter to be associated with this xAPI request. Besides that, this shouldn't be returning a 500 error!
• Activity API
  • Scorm Cloud
    • request: {my Scorm Cloud Endpoint}/activities?activityId=http://www.example.com/tincan/activities/eeXHsQaH
    • response: {"id":"http://www.example.com/tincan/activities/eeXHsQaH","definition":{"name":{"en-US":"Example Activity"},"description":{"en-US":"Example activity definition"}},"objectType":"Activity"}} - _CORRECT_
  • Learning Locker
    • request: {my Learning Locker Endpoint}/activities?activityId=http://www.example.com/tincan/activities/LrNRxzxE
    • response:
      {
      error: true
      message: "key() expects parameter 1 to be array, null given"
      code: 500
      trace: "#0 [internal function]: Illuminate\Exception\Handler->handleError(2, 'key() expects p...', '/var/www/learni...', 40, Array) Remove all the hardcoded analytics / reporting #1
      .... (more stack trace)
      } - _INCORRECT_ This does not conform to the xAPI spec. The activityId parameter does not need to be an array according to the xAPI specification. Making it an array simply returns a different error. Besides that, this shouldn't be returning a 500 error!

Is this a bug in Learning Locker?

[ryasmi]

Thanks for reporting the issues. Both should be fixed in issue/tidyup however that branch is currently unusable. Will let you know when it's usable.

[ht2]

Hi Paul,

Thanks for submitting the issue. I also received an email from Mark about this and I've been in dialogue with Ryan about the situation. We are currently at a place where we have fixed these particular issues as part of a larger drive to refactor our code in the issues/tidyup branch. As we move forward its looking more and more likely that issues/tidup will end up being a 2.0 release of Learning Locker. This obviously has ramifications on conformance fixes that have been made in this branch, as they wouldn't get applied into a 1.x release. As such I have asked Ryan to apply the conformance fixes that have occurred as part of the tidy up, back into the main develop branch. I'm hoping we will be able to push these fixes out (starting with this issue) within the next few days. I'll keep you posted.

James

[ryasmi]

This has now been fixed in the develop branch.