feat(Visualisations): Adds options to display rows for min, max, average, and total for visualisations shown as tables. (LL-151)

[h-kanazawa]

Which issue does this close?

Closes

• https://learningpool.atlassian.net/browse/LL-151
• https://learningpool.atlassian.net/browse/LL-45
• https://learningpool.atlassian.net/browse/LL-46
• https://learningpool.atlassian.net/browse/LL-47
• https://learningpool.atlassian.net/browse/LL-49

Describe your changes providing screenshots of UI changes if necessary.

• Enable show stats in SourceResults
• Viz Refactor custom template PIE, COUNTER, XVSY, and FREQUENCY

[lydiamross]

Looks good!

The ticket says that the totals should be fixed when scrolling to keep them visible but the rest of the rows would disappear as you scroll through the table. Does this not work in reality?

[h-kanazawa]

The ticket says that the totals should be fixed when scrolling to keep them visible but the rest of the rows would disappear as you scroll through the table. Does this not work in reality?

I discussed with @ryansmith94, fixing totals became out of scope of this PR because the design and UX issue. However ScrollableTable component has the options to fix header and footer. Fixing is easy work.

[ryasmi]

Nice Hota. Refactor here looks good too.

[Ian247]

Capitalisation of text is not consistent. Top two toggles both have capitals, bottom toggle does not.

Totals do not stick on table, so when scrolling on either top or bottom selected the values disappear. The table should scroll and the totals remain in place regardless of which option you choose.

[lydiamross]

@Ian247 see Hota's reply a couple of days ago about the scrolling:

I discussed with @ryansmith94, fixing totals became out of scope of this PR because the design and UX issue. However ScrollableTable component has the options to fix header and footer. Fixing is easy work.

[ryasmi]

@lydiamross good spot, don't worry though. Discussed it with Ian and decided that now we don't offer the option to display top and bottom at the same time they can stick. Hota originally implemented this with the stickiness but when top and bottom were shown together you didn't get to see any data rows because there wasn't enough room.

[h-kanazawa]

@Ian247 I capitalised the label "bottom / top". As we discussed, sticking table head/foot is still OFF.

[ryasmi]

Thanks @h-kanazawa please add the stickiness before this is code reviewed again (see my earlier comment about why stickiness is ok now)

[h-kanazawa]

@ryansmith94 Thanks. I read your comment.
This morning, I discussed stickiness with Ian and Ben. Our decision is no stickiness at the moment because sticked tables collapse the design when dashboard widget height is short.

[ryasmi]

Ah okay cool, thanks @h-kanazawa 👍

Resolved.

[HT2Bot]

🎉 This PR is included in version 4.10.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀