fix(Users Page): Prevents errors when users without "manage roles" scope expand users. (LL-143) #1451
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…llScopes Enable to set multiple scopes to a single filter
…and editPublicScopes
h-kanazawa
commented
Sep 11, 2019
| export default getAdminModelFilter({ | ||
| viewAllScope: MANAGE_ALL_ROLES, | ||
| editAllScope: MANAGE_ALL_ROLES, | ||
| viewAllScopes: [MANAGE_ALL_ROLES, MANAGE_ALL_USERS], |
Contributor
Author
There was a problem hiding this comment.
This changing fixes the LL-143. MANAGE_ALL_USERS scope can view roles.
| case 'view': { | ||
| const validScopes = intersection(scopes, [viewAllScope, editAllScope]); | ||
| if (validScopes.length > 0) return getOrgFilter(authInfo); | ||
| const hasValidViewScopes = [...viewAllScopes, ...editAllScopes].some(s => scopes.includes(s)); |
Contributor
Author
There was a problem hiding this comment.
The type of viewAllScope was string. viewAllScopes is string[].
ryasmi
changed the title
Member
|
🎉 This PR is included in version 4.10.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please remember to request a review from someone when this PR is ready for a code review.
Which issue does this close?
Closes https://learningpool.atlassian.net/browse/LL-143
Describe your changes providing screenshots of UI changes if necessary.
org/all/user/managescope becomes to be able to view roles.