Skip to content

🐛 fix: prefix dependabot commit message with ⬆️ gitmoji#23

Merged
JoshuaKGoldberg merged 4 commits intoLearningTypeScript:mainfrom
fuadop:bg/dependabot_commit_message
May 24, 2022
Merged

🐛 fix: prefix dependabot commit message with ⬆️ gitmoji#23
JoshuaKGoldberg merged 4 commits intoLearningTypeScript:mainfrom
fuadop:bg/dependabot_commit_message

Conversation

@fuadop
Copy link
Copy Markdown
Contributor

@fuadop fuadop commented May 22, 2022

PR Checklist

Overview

I hope this fixes it @JoshuaKGoldberg .

Copy link
Copy Markdown
Contributor

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sending! But, this might not work? What does your local system say?

#24 is of note too.

Comment thread .github/dependabot.yml Outdated
- "dependencies" No newline at end of file
- "dependencies"
commit-message:
prefix: "⬆️ "
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, when I run this locally, I get a complaint:

~/repos/learning-typescript-projects$ echo "⬆️ build(deps-dev): bump ts-jest from 28.0.0 to 28.0.2" | npx commitlint
⧗   input: ⬆️ build(deps-dev): bump ts-jest from 28.0.0 to 28.0.2
✖   Your commit should start with gitmoji code,please check the emoji code on https://gitmoji.dev/. [start-with-gitmoji]
✖   subject may not be empty [subject-empty]
✖   type may not be empty [type-empty]

✖   found 3 problems, 0 warnings
ⓘ   Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint

Do you?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't get this but, let me push a change in another format.. let me write it in gitmoji format instead of emoji.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you try it now? I used gitmoji instead of emoji now.

Copy link
Copy Markdown
Contributor

@JoshuaKGoldberg JoshuaKGoldberg May 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

echo ":arrow_up: build(deps-dev): bump abc to 123" | npx commitlint works for me! 🚀

I can't find a way to get Dependabot to create a new pull request (do you know of one?), so I guess we have to ... wait until the next update comes in? 😂

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea we have to wait till another dependency update 😅

@fuadop fuadop requested a review from JoshuaKGoldberg May 23, 2022 21:40
Copy link
Copy Markdown
Contributor

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try it out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dependabot PRs don't adhere to PR title commitlint config

2 participants