LRN 17472 - Update to .NET Standard #15
Conversation
gonzalozawa
commented
Nov 24, 2017
gonzalozawa
commented
- Remove legacy solution file: LearnositySDK-VS2010.sln
- Update to .Net Standard
- Update Newtonsoft dependency to version 10.0.3 - This was needed when updating to .Net Standard
- Change LearnositySDK project to a Class Library that targets .NET Standard framework 2.0
- Update LearnositySDK project to build a Nuget package
|
Hi @karoltarasiuk, I have resolved the conflicts on this branch with master. Can you please have a look now and review? |
| <OutputType>Library</OutputType> | ||
| <AppDesignerFolder>Properties</AppDesignerFolder> | ||
| <RootNamespace>LearnositySDK</RootNamespace> | ||
| <TargetFramework>netstandard2.0</TargetFramework> |
There was a problem hiding this comment.
@gonzalozawa what did you pick the version of .NET standard based on? They recommend:
to target the lowest version of .NET Standard possible
There was a problem hiding this comment.
@karoltarasiuk this is a great question. I've tried using a lower version of .NET Standard but the project doesn't compile and throw errors. Mainly on Remote.cs and Init.cs
The problem in that particular classes is that System.Web and System.Net aren't included in the previous version of .NET Standard. See https://stackoverflow.com/questions/30227219/how-to-use-webclient-with-netcore
Do you think I should try to fix those classes and use .NET Core functionality or should we just target .NET Standard 2.0 ?
There was a problem hiding this comment.
Cool, makes sense. I think that in this case we leave it as is and only come back to it if somebody complains :)
|
@gonzalozawa I think all we need then is a squash and merge. |
