Fix: global transition bug when there are empty virtuals

[bigredfrog]

Virtuals with no segments have no transitions
If transitions is set to global then virtuals posts would fail due to attempting to access transitions of all virtuals
Only attempt setting transitions if member is present

Summary by CodeRabbit

• Bug Fixes
  • Improved system stability by adding safeguards during configuration updates, ensuring that settings are only applied when applicable. This prevents potential runtime issues and results in a smoother, more reliable user experience.

[coderabbitai]

Walkthrough

The update in the ledfx/virtuals.py file modifies the config method in the Virtual class. It adds a conditional check to verify if the virtual object has the frame_transitions attribute before setting related values. If the attribute exists, it assigns proper values; if not, it logs an informational message. This adjustment prevents potential runtime errors due to missing attributes.

Changes

File(s)	Summary
ledfx/virtuals.py	Added a conditional check for the existence of the frame_transitions attribute in Virtual.config; assigns values if present, otherwise logs an info message to avoid an AttributeError.

Sequence Diagram(s)

sequenceDiagram
    participant V as Virtual.config
    participant O as Virtual Object
    participant L as Logger

    V->>O: Check if "frame_transitions" exists
    alt Attribute exists
        V->>O: Assign frame_transitions, _config["transition_time"], _config["transition_mode"]
    else Attribute missing
        V->>L: Log info "virtual object does not have transitions"
    end

Loading

Possibly related PRs

• Fix: Protect against mismatched shapes during transitions #1126: Enhances the handling of frame assemblies in the Virtual class with validation logic, directly related to the safe attribute access introduced in this PR.

Poem

I hop with joy through code so neat,
Where checks ensure transitions meet.
No more tripping on missing keys,
I log the note with utmost ease.
Celebrating changes – a rabbit's upbeat beat! 🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 657b706 and 037c7d4.

📒 Files selected for processing (1)

• ledfx/virtuals.py (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (12)

• GitHub Check: Build LedFx (Ubuntu) (3.12)
• GitHub Check: Build LedFx (OS X) (3.12)
• GitHub Check: Build LedFx (Ubuntu) (3.11)
• GitHub Check: Build LedFx (Windows) (3.12)
• GitHub Check: Build LedFx (OS X) (3.11)
• GitHub Check: Build LedFx (Ubuntu) (3.10)
• GitHub Check: Build LedFx (Windows) (3.11)
• GitHub Check: Build LedFx (OS X) (3.10)
• GitHub Check: Build LedFx (Ubuntu) (3.9)
• GitHub Check: Build LedFx (Windows) (3.10)
• GitHub Check: Build LedFx (OS X) (3.9)
• GitHub Check: Build LedFx (Windows) (3.9)

🔇 Additional comments (1)

ledfx/virtuals.py (1)

1143-1156: Added necessary check for frame_transitions attribute.

The code now checks if a virtual has the frame_transitions attribute before attempting to set values to it. This prevents AttributeError exceptions when processing empty virtuals that don't have this attribute.

This fix properly addresses the global transition bug mentioned in the PR objectives, where the system was attempting to access transitions for all virtuals, including empty ones that don't have the required attributes.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.