Conversation
WalkthroughUpdated macOS GitHub Actions runners from Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.github/workflows/ci-build.yml(1 hunks).github/workflows/test-build-binaries.yml(3 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: Build LedFx (OS X) (Apple Silicon) (3.9)
- GitHub Check: Build LedFx (Ubuntu) (3.12)
- GitHub Check: Build LedFx (Ubuntu) (3.11)
- GitHub Check: Build LedFx (Ubuntu) (3.9)
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/ci-build.yml(1 hunks)
🧰 Additional context used
🪛 actionlint (1.7.7)
.github/workflows/ci-build.yml
105-105: label "macos-15-intel" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-24.04-arm", "ubuntu-22.04", "ubuntu-22.04-arm", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (11)
- GitHub Check: Build LedFx Docker Image for arm64
- GitHub Check: Build LedFx (OS X) (Apple Silicon) (3.10)
- GitHub Check: Build LedFx (OS X) (Apple Silicon) (3.9)
- GitHub Check: Build LedFx (OS X) (3.9)
- GitHub Check: Build LedFx (OS X) (3.11)
- GitHub Check: Build LedFx (OS X) (3.10)
- GitHub Check: Build LedFx (Ubuntu) (3.11)
- GitHub Check: Build LedFx (Ubuntu) (3.10)
- GitHub Check: Build LedFx (Ubuntu) (3.9)
- GitHub Check: Build LedFx (Ubuntu) (3.12)
- GitHub Check: Build LedFx (Windows) (3.10)
🔇 Additional comments (1)
.github/workflows/ci-build.yml (1)
156-158: Confirm CMake honorsCMAKE_POLICY_VERSION_MINIMUMI can’t find documentation that the environment variable
CMAKE_POLICY_VERSION_MINIMUMis consumed by CMake. Please double-check that this really flips the intended policy (e.g., via a quick configure log check) or adjust to the officially supported mechanism.
| build-ledfx-osx: | ||
| name: Build LedFx (OS X) | ||
| runs-on: macos-13 | ||
| runs-on: macos-15-intel |
There was a problem hiding this comment.
Update actionlint (or whitelist the new runner)
macos-15-intel is valid on GitHub, but actionlint 1.7.7 still flags it as unknown, which keeps our lint job red. Please bump actionlint to a release that knows this label or add it to the runner-labels allow-list in actionlint.yaml before landing.
🧰 Tools
🪛 actionlint (1.7.7)
105-105: label "macos-15-intel" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-24.04-arm", "ubuntu-22.04", "ubuntu-22.04-arm", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
🤖 Prompt for AI Agents
In .github/workflows/ci-build.yml around line 105, actionlint flags the new
runner label macos-15-intel as unknown; fix by either updating the actionlint
version used in the workflow to a release that recognizes macos-15-intel (bump
the action/image or actionlint binary reference to a newer tag) or add
"macos-15-intel" to the runner-labels allow-list in actionlint.yaml (add the
label string under the runner-labels key and commit); choose one approach,
update the corresponding file, and re-run the lint job to confirm the warning is
resolved.
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/test-build-binaries.yml (1)
98-98: Switching the x64 jobs tomacos-15-intelkeeps them on Intel hardwareThis preserves the expected architecture for PyInstaller builds, smoke tests, and release packaging. Looks good. If you have actionlint wired into CI, you may need to bump it (or whitelist the new label) so it stops flagging
macos-15-intelas unknown.Also applies to: 397-397, 443-443
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/test-build-binaries.yml(3 hunks)
🧰 Additional context used
🪛 actionlint (1.7.7)
.github/workflows/test-build-binaries.yml
98-98: label "macos-15-intel" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-24.04-arm", "ubuntu-22.04", "ubuntu-22.04-arm", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
397-397: label "macos-15-intel" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-24.04-arm", "ubuntu-22.04", "ubuntu-22.04-arm", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
443-443: label "macos-15-intel" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-24.04-arm", "ubuntu-22.04", "ubuntu-22.04-arm", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (11)
- GitHub Check: Build LedFx (OS X) (Apple Silicon) (3.11)
- GitHub Check: Build LedFx (Ubuntu) (3.12)
- GitHub Check: Build LedFx (OS X) (Apple Silicon) (3.10)
- GitHub Check: Build LedFx (Ubuntu) (3.9)
- GitHub Check: Build LedFx (OS X) (3.11)
- GitHub Check: Build LedFx (Ubuntu) (3.11)
- GitHub Check: Build LedFx (Windows) (3.11)
- GitHub Check: Build LedFx (OS X) (3.9)
- GitHub Check: Build LedFx (Windows) (3.10)
- GitHub Check: Build LedFx (OS X) (3.10)
- GitHub Check: Build LedFx (Ubuntu) (3.10)
1 participant
Speculative bump in response to notice below.
Wondering why we have a mix of macos-13 and macos-latest
The macOS 13 runner image will be retired by December 4th, 2025. To raise awareness of the upcoming removal, jobs using macOS 13 will temporarily fail during the scheduled brownout time periods defined below:
November 4, 14:00 UTC - November 5, 00:00 UTC
November 11, 14:00 UTC - November 12, 00:00 UTC
November 18, 14:00 UTC - November 19, 00:00 UTC
November 25, 14:00 UTC - November 26, 00:00 UTC
This deprecation includes the following labels:
macos-13
macos-13-large
macos-13-xlarge
What you need to do
(Recommended) If your workflow is architecture agnostic, you can migrate to any of our arm64 labels:
macos-15 or macos-latest
macos-14
macos-14-xlarge
macos-latest-xlarge or macos-15-xlarge
For users that require the x86_64 (Intel) architecture, jobs can be migrated to one of the following labels:
macos-15-intel (new)
macos-14-large
macos-latest-large or macos-15-large
You can always get up-to-date information on our tools by reading about the software in the runner images repository. Please contact GitHub Support if you run into any problems or need help.
Notice of macOS x86_64 (Intel) architecture deprecation
Apple has discontinued support for the x86_64 (Intel) architecture going forward. GitHub will no longer support this architecture on macOS after the macOS 15 runner image is retired in Fall 2027. You should begin migrating your workloads to arm64-based (Apple Silicon) runners as soon as possible to prepare for this eventual deprecation.
Best,
The GitHub Team
Summary by CodeRabbit