Merged
Conversation
Add an integration test that requires the preprocessor to honour a user-supplied `-I` directory. The fixture places `inner.h` in a sibling subdirectory `inc/` so the includer's-own-directory rule cannot find it. The `.flags` sidecar passes `-I tests/user_include_path_resolution/inc` and the test only passes if absolution forwards that path to `comp.search_path`. This currently fails on v1.1.1 because `Driver.parseArgs` accumulates `-I/-isystem/-iquote/-idirafter` into `driver.includes` but `Parser.init` never commits the result to the compilation's search path, so every user-supplied include path is invisible to the preprocessor. The next commit restores that wiring and turns the test green.
Collaborator
|
Nice catch I'll have a look at it later this week 🙌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey @0pendev — tried bumping my fuzz pipeline to v1.1.1 and hit a regression where every user-supplied
-I/-isystem/-iquote/-idirafteris dropped (only-Dsurvives). Same flags work on v1.1.0.I poked at it a bit and it looks like user includes never make it from
driver.includesto the preprocessor's search path — small tweak inParser.init+include_paths.zigand it's happy again. Tossed in a regression test too. Tests pass and my campaigns run fine on this build. Mind taking a look when you have a sec? 🙏